cgroupv2: don't try to set kmem for systemd case#2270
Merged
mrunalp merged 1 commit intoopencontainers:masterfrom Mar 26, 2020
Merged
cgroupv2: don't try to set kmem for systemd case#2270mrunalp merged 1 commit intoopencontainers:masterfrom
mrunalp merged 1 commit intoopencontainers:masterfrom
Conversation
To the best of my knowledge, it has been decided to drop the kernel memory controller from the cgroupv2 hierarchy, so "kernel memory limits" do not exist if we're using v2 unified. So, we need to ignore kernel memory setting. This was already done in non-systemd case (see commit 88e8350), let's do the same for systemd. This fixes the following error: > container_linux.go:349: starting container process caused "process_linux.go:306: applying cgroup configuration for process caused \"open /sys/fs/cgroup/machine.slice/runc-cgroups-integration-test.scope/tasks: no such file or directory\"" Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
Contributor
Author
|
This PR does not come with a test case as I am currently working on updating our existing cgroup integration tests (those in tests/integration/update.bats) for v2, and will do a separate PR once it's ready for review. |
Member
|
LGTM, thanks |
Contributor
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To the best of my knowledge, it has been decided to drop the kernel
memory controller from the cgroupv2 hierarchy, so "kernel memory limits"
do not exist if we're using v2 unified.
So, we need to ignore kernel memory setting. This was already done in
non-systemd case (see commit 88e8350), let's do the same for systemd.
This fixes the following error:
@AkihiroSuda @mrunalp PTAL