Skip to content

temporarily disable CRIU tests#2198

Merged
hqhq merged 2 commits intoopencontainers:masterfrom
AkihiroSuda:criu-master
Jan 14, 2020
Merged

temporarily disable CRIU tests#2198
hqhq merged 2 commits intoopencontainers:masterfrom
AkihiroSuda:criu-master

Conversation

@AkihiroSuda
Copy link
Member

@AkihiroSuda AkihiroSuda commented Jan 1, 2020

update criu to the latest revision on criu-dev branch (v3.13 is not enough to fix the issue)

Fix #2196

EDIT: Changed PR to skip the tests until Ubuntu kernel gets fixed (#2198 (comment))

contains #2206

@crosbymichael
Copy link
Member

now it's worse :)

@AkihiroSuda AkihiroSuda changed the title Dockerfile: update criu (Dec 28, 2019 master) Dockerfile: update criu (Jan 4, 2019) Jan 6, 2020
@AkihiroSuda
Copy link
Member Author

@adrianreber Is this planned to be fixed soon? Should we skip CRIU tests?

@adrianreber
Copy link
Contributor

I was not aware of this. As this seems to be Travis related I guess this could be:

https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1857257

With updated Ubuntu kernels with have also seen CRIU errors. So far this seems to be Ubuntu only.

@adrianreber
Copy link
Contributor

Is this planned to be fixed soon?

As this seems to be right now a Ubuntu only problem, I have no real idea. We switched to using docker with graphdriver devicemapper or Podman with graphdriver vfs.

Should we skip CRIU tests?

I really do not want to say to skip CRIU tests, but maybe that is necessary if above workarounds are not a solution for you. Maybe adding a comment to the Ubuntu bug would help to highlight this problem.

AkihiroSuda added a commit to AkihiroSuda/runc that referenced this pull request Jan 7, 2020
Ubuntu kernel is temporarily broken: opencontainers#2198 (comment)

Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
@AkihiroSuda AkihiroSuda changed the title Dockerfile: update criu (Jan 4, 2019) temporarily disable CRIU tests Jan 7, 2020
@AkihiroSuda
Copy link
Member Author

Changed PR to skip the tests until Ubuntu kernel gets fixed

@crosbymichael
Copy link
Member

crosbymichael commented Jan 7, 2020

LGTM

Approved with PullApprove

AkihiroSuda added a commit to AkihiroSuda/runc that referenced this pull request Jan 14, 2020
Ubuntu kernel is temporarily broken: opencontainers#2198 (comment)

Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
A new method was added to the cgroup interface when opencontainers#2177 was merged.

After opencontainers#2177 got merged, opencontainers#2169 was merged without rebase (sorry!) and compilation was failing:

  libcontainer/cgroups/fs2/fs2.go:208:22: container.Cgroup undefined (type *configs.Config has no field or method Cgroup)

Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
Ubuntu kernel is temporarily broken: opencontainers#2198 (comment)

Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
@AkihiroSuda
Copy link
Member Author

Rebased and green. Now contains #2206

@AkihiroSuda
Copy link
Member Author

@cyphar @mrunalp @hqhq @dqminh PTAL?

@cyphar
Copy link
Member

cyphar commented Jan 14, 2020

Ah, I'll close #2206 since it's really hard to track which PRs contain each other...

@cyphar
Copy link
Member

cyphar commented Jan 14, 2020

LGTM, but please open a tracking bug to re-enable the CRIU tests.

Approved with PullApprove

@AkihiroSuda
Copy link
Member Author

tracking issue: #2208

@AkihiroSuda
Copy link
Member Author

merge?

@hqhq
Copy link
Contributor

hqhq commented Jan 14, 2020

LGTM

Approved with PullApprove

@hqhq hqhq merged commit 709377c into opencontainers:master Jan 14, 2020
adrianreber pushed a commit to adrianreber/runc that referenced this pull request Feb 10, 2020
Ubuntu kernel is temporarily broken: opencontainers#2198 (comment)

Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CRIU tests are failing on CI

5 participants