Skip to content

libcontainer: CurrentGroupSubGIDs -> CurrentUserSubGIDs #1880

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
crosbymichael merged 1 commit into from
Oct 16, 2018
Merged

libcontainer: CurrentGroupSubGIDs -> CurrentUserSubGIDs #1880

crosbymichael merged 1 commit into from
Oct 16, 2018

Conversation

@AkihiroSuda
Copy link
Member

@AkihiroSuda AkihiroSuda commented Aug 28, 2018 •
edited
Loading

subgid is defined per user, not group (see subgid(5))

This commit also adds support for specifying subuid owner with a numeric UID.

Signed-off-by: Akihiro Suda suda.akihiro@lab.ntt.co.jp

@AkihiroSuda
Copy link
Member Author

AkihiroSuda commented Aug 28, 2018

Note that these functions are not used by runc itself, and looks like only consumed by RootlessKit: https://github.com/search?q=currentgroupsubgids&type=Code

Maybe we can just remove these functions instead.

@AkihiroSuda AkihiroSuda mentioned this pull request Aug 28, 2018
Closed
@AkihiroSuda
libcontainer: CurrentGroupSubGIDs -> CurrentUserSubGIDs
b34d6d8 
subgid is defined per user, not group (see subgid(5))

This commit also adds support for specifying subuid owner with a numeric UID.

Signed-off-by: Akihiro Suda <suda.akihiro@lab.ntt.co.jp>
crosbymichael
crosbymichael reviewed Sep 10, 2018
View reviewed changes
libcontainer/user/lookup_unix.go
return ParseSubIDFileFilter(fileName, filter)
}

func CurrentGroupSubGIDs() ([]SubID, error) {
Copy link
Member

@crosbymichael crosbymichael Sep 10, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this going to break anyone?

Copy link
Member Author

@AkihiroSuda AkihiroSuda Sep 10, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AFAIK no #1880 (comment)

@AkihiroSuda
Copy link
Member Author

AkihiroSuda commented Sep 11, 2018

@cyphar PTAL?

@AkihiroSuda AkihiroSuda mentioned this pull request Oct 16, 2018
Merged
@cyphar
Copy link
Member

cyphar commented Oct 16, 2018 •
edited by caniszczyk
Loading

LGTM.

Approved with PullApprove

@crosbymichael
Copy link
Member

crosbymichael commented Oct 16, 2018 •
edited by caniszczyk
Loading

LGTM

Approved with PullApprove

@crosbymichael crosbymichael merged commit 58592df into opencontainers:master Oct 16, 2018
@thaJeztah thaJeztah mentioned this pull request Nov 6, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@crosbymichael crosbymichael crosbymichael left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@AkihiroSuda @cyphar @crosbymichael