-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Expand support for container id naming #676
Copy link
Copy link
Closed
Description
Currently we limit container ids through regex to \w ascii numbers and letters and a few additional selected chars.
The spec has no such limit.
Suggest changing the code in one of the following ways to add the ability to support unicode names:
- do a touch cid to see if the OS supports it as a filename and report otherwise
- figure out how to the fix the expression for the plethora of unicode chars that should also be valid
- hash the passed in cid, store the original in the container's state.. (slow)
- @wrking suggestions: use percent-encoding or base64-encoding before using them as filenames
https://tools.ietf.org/html/rfc3986#section-2.1
http://tools.ietf.org/html/rfc4648#section-54
Opening the issue for discussion... I offer to do a PR based on discussions.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels