Skip to content

(regression in master) not ok 117 update devices [minimal transition rules] #3014

@kolyshkin

Description

@kolyshkin

Got an error from CI for PR #3011, during test (1.16.x) integration test with systemd. Also reproducible on master and other recent PRs.

Quoting https://github.com/opencontainers/runc/runs/2787163520?check_suite_focus=true:

not ok 117 update devices [minimal transition rules]
# (in test file tests/integration/update.bats, line 625)
#   `[ -z "$(<"$CONTAINER_OUTPUT")" ]' failed
# runc spec (status=0):
# 
# runc run -d --console-socket /tmp/bats-run-25456/runc-tmp-recvtty.9wbHaU/console.sock test_update (status=0):
# 
# runc update --pids-limit 30 test_update (status=0):
# 
# runc update --pids-limit 30 test_update (status=0):
# 
# runc update --pids-limit 30 test_update (status=0):
# 
# runc update --pids-limit 30 test_update (status=0):
# 
# runc update --pids-limit 30 test_update (status=0):
# 
# runc update --pids-limit 30 test_update (status=0):
# 
# runc update --pids-limit 30 test_update (status=0):
# 
# runc update --pids-limit 30 test_update (status=0):
# 
# runc update --pids-limit 30 test_update (status=0):
# 
# runc update --pids-limit 30 test_update (status=0):
# 
# runc update --pids-limit 30 test_update (status=0):
# 
# runc update --pids-limit 30 test_update (status=0):
# 
# sh: can't create /dev/null: Operation not permitted
# /tmp/bats-run-25456/bats.37480.src: line 603: 39193 Killed                  ( "$RECVTTY" --no-stdin --pid-file "$TMP_RECVTTY_PID" --mode single "$TMP_CONSOLE_SOCKET" &> "$CONTAINER_OUTPUT" )

The test case was added in commit 4438eaa, PR #2391.

This sh: can't create /dev/null: Operation not permitted means somewhere during runc update the device access list might become empty for some time.

May be related to recent PR #2994 (although I do not see how). Definitely not related to PR #2986 as we have cgroup v1 here.

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions