Skip to content

setting Resources.MemorySwap unlimited after type change is messy #1421

@sjenning

Description

@sjenning

#1375 changed Resources.MemorySwap to a uint64.

https://github.com/opencontainers/runc/blob/master/libcontainer/configs/cgroup_unix.go#L53-L54

Comment on that field is set to -1 for unlimited, which can't be done with a uint64

This is blocking a vendored dep bump in kube: kubernetes/kubernetes#43856

@derekwaynecarr

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions