Use go-digest to replace manual assembly of the digest#542
Merged
jonboulle merged 1 commit intoopencontainers:masterfrom Jan 31, 2017
yongtang:513-go-digest
Merged
Use go-digest to replace manual assembly of the digest#542jonboulle merged 1 commit intoopencontainers:masterfrom yongtang:513-go-digest
jonboulle merged 1 commit intoopencontainers:masterfrom
yongtang:513-go-digest
Conversation
This fix changes the manual assembly of the digest (sha256) in `schema/manifest_backwards_compatibility_test.go`, as go-digest is already in place in github.com/opencontainers. This fix fixes #513. Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
Contributor
|
lgtm |
1 similar comment
Contributor
|
lgtm |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fix changes the manual assembly of the digest (sha256) in
schema/manifest_backwards_compatibility_test.go, asgo-digestis already in place in github.com/opencontainers.This fix fixes #513.
Signed-off-by: Yong Tang yong.tang.github@outlook.com