improve walk function on returning result#201
Merged
vbatts merged 1 commit intoopencontainers:masterfrom Aug 31, 2016
xiekeyang:refactor
Merged
improve walk function on returning result#201vbatts merged 1 commit intoopencontainers:masterfrom xiekeyang:refactor
vbatts merged 1 commit intoopencontainers:masterfrom
xiekeyang:refactor
Conversation
Signed-off-by: xiekeyang <xiekeyang@huawei.com>
Contributor
|
cc @s-urbaniak can you please review? |
Contributor
|
Or we can drop the walker-based approach. #159 has explicit errors for “blob/ref not found”. |
Collaborator
|
lgtm, thanks! It introduces a bit of redundancy, but that is fine with me. |
Member
|
LGTM |
1 similar comment
Contributor
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
nilin the case of no-error.Signed-off-by: xiekeyang xiekeyang@huawei.com