Conversation
Signed-off-by: Vincent Batts <vbatts@hashbangbash.com>
Signed-off-by: Vincent Batts <vbatts@hashbangbash.com>
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
|
|
||
| // VersionDev indicates development branch. Releases will be empty string. | ||
| VersionDev = "-dev" | ||
| VersionDev = "-rc.3-dev" |
There was a problem hiding this comment.
Actually, I just remembered -- using -dev this way results in suboptimal behaviour with SemVer. SemVer treats 1.0.0-dev as being a pre-release of 1.0.0 -- meaning that the -dev version is seen as "older". Another issue is that -dev is not really a pre-release (and it's definitely not a pre-release of the previously-released version).
In runc and umoci we use +dev because that matches the correct version order behaviour with rpm and most other tools (1.0.1 > 1.0.0+dev > 1.0.0), though under SemVer 1.0.0+dev == 1.0.0 (I don't think this is a problem for a specification though, but maybe that's just me).
Maybe we should use +dev as well?
There was a problem hiding this comment.
Ah, this is outlined in RELEASES.md. I will submit a PR to make the change for future releases.
to tag
this is would mean tagging 085b884 as v1.1.0-rc.3 (now with more SemVer)
changes
fd45b6b Add scratch descriptor and scope layer limits
63b8bd0 Remove artifact manifest
23c4647 Define image manifest artifactType and guidance
5751791 Add Tianon as maintainer
f4fc83a Fix unused variable linting error
d09d13d Update Jon Johnson's email
4136bec descriptor schema: add missing data and artifactType definitions
729a03e manifest, specs-go/: provide guidance on SCRATCH config descriptor
31de013 manifest schema: add tests for the subject field
7a9efbd manifest schema: add the missing
subjectfieldf2f1956 descriptor: clarify artifactType field must have compliant values
98f35df Update image spec and conversion to clarify groups
336b02c Require IANA mediaType for image config.mediaType and layers.mediaType
1f60184 Add Go 1.20 support
f99b121 Remove filtersApplied from image-spec
b5998ba specs-go/v1/*.go: align the deprecation style
6687119 Chore: fix go.mod - split direct/indirect dependencies
867ce74 ArtifactType is optional, omit when empty
ccb86b9 mention deprecation in media-types.md
9b4e6c0 even fewer words
2cdbef2 Deprecate non-distributable layers
265874e Note an exception to the platform.os recommendation for wasi
59780aa Add ArgsEscaped field to image config
3625ee3 doc: fix example in artifact.md
94f2431 version: bump main back to -dev
0a97fe7 docs: Added artifact.md to docs and spec.md
ca2e500 Embed Platform in Image
293f064 Reverting json schema to well known value