conformance: make blob mount and upload checks more strict#399
conformance: make blob mount and upload checks more strict#399sudo-bmitch merged 1 commit intoopencontainers:mainfrom
Conversation
Signed-off-by: Jason Hall <jason@chainguard.dev>
|
Also, I'm not sure what automated checks we have on conformance test changes to check that this doesn't regress on any currently-passing registries. |
jdolitsky
left a comment
There was a problem hiding this comment.
Also, I'm not sure what automated checks we have on conformance test changes to check that this doesn't regress on any currently-passing registries.
There isnt any currently, just individual projects running off main in CI
we used the term name instead of repo to avoid namespace and repository format requirements 1hr approve and merge? That must be a record :-O If memory serves at one point v1 docker api was considered acceptable for certain scenarios.. probably why this wasn't necessarily restricted? |
Locationresponse header to be exactly/v2/<repo>/blobs/<digest>, and not just contain the string<repo>Locationpoints to an upload session URL, require theLocationresponse header to start with/v2/<repo>/blobs/uploads/, and not just contain/blobs/uploads/.In the case of (2), this corresponds to common behavior, but based on my reading of the spec it might not actually be exactly specified as such:
(source)
We may want to clarify this failed-mounting behavior more to specify that the
Locationresponse header MUST be/v2/<repo>/blobs/uploads/, as it normally is.