Add conformance test coverage for data field#318
Merged
vbatts merged 1 commit intoopencontainers:mainfrom Aug 17, 2022
Merged
Conversation
Signed-off-by: Jason Hall <jasonhall@redhat.com>
Contributor
|
fire. let me test this out and report back |
jdolitsky
approved these changes
Mar 4, 2022
Contributor
jdolitsky
left a comment
There was a problem hiding this comment.
Tried on Bundle Bar, distribution/distribution, and zot. No failures related to the addition of this field
mikebrow
reviewed
Mar 11, 2022
| Size int64 `json:"size"` | ||
|
|
||
| // Data specifies the data of the object described by the descriptor. | ||
| Data []byte `json:"data"` |
Member
There was a problem hiding this comment.
from the referenced commit
// Data is an embedding of the targeted content. This is encoded as a base64
// string when marshalled to JSON (automatically, by encoding/json). If
// present, Data can be used directly to avoid fetching the targeted content.
Data []byte `json:"data,omitempty"`
don't see how Data could be empty from this test bucket.. just a nit...
Member
Author
There was a problem hiding this comment.
It doesn't even seem to matter either way. An empty []byte with and without the struct tag results in {} in my tests in the Go Playground.
Contributor
|
Adding #321 for tracking |
Contributor
|
@opencontainers/distribution-spec-maintainers - can we get another +1? |
Member
Author
|
Friendly ping. |
vbatts
approved these changes
Aug 17, 2022
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
dataproposal was merged: opencontainers/image-spec#826 🎉This adds some conformance test coverage that the new field is round-trippable through registries, helpfully piggybacking off of #311. Since registries don't validate that the contents match it doesn't seem fair to add that case to conformance, but it's something to consider in the future.
@jdolitsky