Skip to content

enhancement(Tiers): make presets coherent with min amount#10789

Merged
Betree merged 8 commits intoopencollective:mainfrom
Myestery:tiers-validation
Nov 15, 2024
Merged

enhancement(Tiers): make presets coherent with min amount#10789
Betree merged 8 commits intoopencollective:mainfrom
Myestery:tiers-validation

Conversation

@Myestery
Copy link
Copy Markdown
Contributor

@Myestery Myestery commented Nov 10, 2024 •
edited
Loading

Resolve Issue with validation within tiers

Description

This PR adds a validation message when a user is trying to pay lesser than the minimum amount for a collective and also trys to prevent that when setting tiers on the dashboard.

Screenshots

ezgif-5-5fe4c9d7ae

@vercel
Copy link
Copy Markdown

vercel bot commented Nov 10, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
opencollective-frontend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 15, 2024 7:59am
opencollective-styleguide ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 15, 2024 7:59am

@Myestery Myestery marked this pull request as ready for review November 10, 2024 17:31
@Myestery Myestery mentioned this pull request Nov 11, 2024
Closed
@Myestery Myestery changed the title Add minimum amount validation message in StepDetails component Tier Validation Nov 11, 2024
Betree
Betree reviewed Nov 12, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@Betree Betree left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The core implementation is great, relying on the standard min attribute is a good approach. Some requested changes below to make it ready to ship!

Comment thread components/contribution-flow/StepDetails.js Outdated
Comment thread components/contribution-flow/StepDetails.js Outdated
@Betree Betree changed the title Tier Validation enhancement(Tiers): make presets coherent with min amount Nov 12, 2024
@Betree Betree mentioned this pull request Nov 12, 2024
Merged
@Betree
Copy link
Copy Markdown
Member

Betree commented Nov 12, 2024

Note for the team: we should merge & deploy opencollective/opencollective-api#10439 at the same time.

@Myestery
Copy link
Copy Markdown
Contributor Author

Myestery commented Nov 12, 2024

I have made the edits as requested

Betree
Betree reviewed Nov 13, 2024
View reviewed changes
Comment thread components/contribution-flow/StepDetails.js Outdated
@Betree
Copy link
Copy Markdown
Member

Betree commented Nov 13, 2024

@Myestery I confirmed the bounty a bit too fast here, the language files were not updated and the linting was not passing. For your next contribution, make sure you run npm run build:langs and npm run lint before pushing your changes. Thank you!

@Myestery
Copy link
Copy Markdown
Contributor Author

Myestery commented Nov 13, 2024 •
edited
Loading

@Myestery I confirmed the bounty a bit too fast here, the language files were not updated and the linting was not passing. For your next contribution, make sure you run npm run build:langs and npm run lint before pushing your changes. Thank you!

Thank you, I was about to start fixing the linting issues.
Will do so next time

@Betree Betree merged commit 90cd3ad into opencollective:main Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Betree Betree Betree approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Tier validation: prevent setting a preset lower than the minimum amount

2 participants

@Myestery @Betree