fix(ui): repair iOS Safari chat viewport handling#92855
Conversation
Co-authored-by: Xi Qi <1311124+macdao@users.noreply.github.com>
|
Codex review: needs maintainer review before merge. Reviewed June 13, 2026, 11:33 PM ET / 03:33 UTC. Summary PR surface: Source -8. Total -8 across 1 file. Reproducibility: yes. from source evidence: the related source PR describes opening the Control UI chat on iPhone Safari, observing the global scrollbar/full-height issue, and focusing the composer input. I did not run a live iPhone Safari reproduction in this read-only review. Review metrics: none identified. Merge readiness Overall follows the weaker of proof and patch quality, so missing proof can cap an otherwise strong patch. Rank-up moves:
Proof guidance:
Mantis proof suggestion Risk before merge
Maintainer options:
Next step before merge
Security Review detailsBest possible solution: Land this small replacement only after branch-specific mobile Safari proof shows no global scrollbar and no composer-focus zoom, while keeping the source PR credited and linked. Do we have a high-confidence way to reproduce the issue? Yes from source evidence: the related source PR describes opening the Control UI chat on iPhone Safari, observing the global scrollbar/full-height issue, and focusing the composer input. I did not run a live iPhone Safari reproduction in this read-only review. Is this the best way to solve the issue? Yes, with proof still needed: removing the chat-only duplicate height is a narrow fix because base AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning high; reviewed against 7f49f875de1b. Label changesLabel changes:
Label justifications:
Evidence reviewedPR surface: Source -8. Total -8 across 1 file. View PR surface stats
Acceptance criteria:
What I checked:
Likely related people:
What the crustacean ranks mean
Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics. How this review workflow works
|
Summary
Review blockers to clear
Validation
Credit: this repair carries forward @macdao's original work in #63644.
Clownfish 🐠 replacement reef notes:
fish notes: model gpt-5.5, reasoning xhigh; reviewed against 62f0150.