Remove bundled channel contract fallbacks#91871
Conversation
|
Codex review: needs real behavior proof before merge. Reviewed June 10, 2026, 3:15 AM ET / 07:15 UTC. Summary PR surface: Source -109, Tests +78. Total -31 across 29 files. Reproducibility: not applicable. this is a refactor PR, not a bug report with a current-main failure to reproduce. Source review can verify the loader behavior, but the remaining gate is package/upgrade proof after the cutover. Review metrics: 1 noteworthy metric.
Merge readiness Overall follows the weaker of proof and patch quality, so missing proof can cap an otherwise strong patch. Rank-up moves:
Proof guidance:
Risk before merge
Maintainer options:
Next step before merge
Security Review detailsBest possible solution: Land only after maintainers accept the fallback cutover and there is real package or upgrade proof that the affected bundled channels resolve their canonical sidecars; otherwise keep the shipped fallback until a deprecation path is explicit. Do we have a high-confidence way to reproduce the issue? Not applicable: this is a refactor PR, not a bug report with a current-main failure to reproduce. Source review can verify the loader behavior, but the remaining gate is package/upgrade proof after the cutover. Is this the best way to solve the issue? Unclear as merge-ready until upgrade proof exists: the source shape is cleaner and keeps external plugin fallback discovery intact, but removing the shipped bundled fallback is a maintainer compatibility decision. AGENTS.md: found and applied where relevant. Codex review notes: model gpt-5.5, reasoning high; reviewed against a3d5e5bc7247. Label changesLabel changes:
Label justifications:
Evidence reviewedPR surface: Source -109, Tests +78. Total -31 across 29 files. View PR surface stats
What I checked:
Likely related people:
What the crustacean ranks mean
Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics. How this review workflow works
|
48cf443 to
94b0e56
Compare
|
Land-ready proof:
Known gaps: none. |
|
Landed via rebase merge. Final commits on
Proof before merge: scoped Vitest, core/extensions tsgo probes, |
Summary
Verification