Skip to content

fix: preserve live Ollama catalog metadata#91248

Merged
steipete merged 1 commit into
mainfrom
fix/ollama-catalog-live-metadata
Jun 7, 2026
Merged

fix: preserve live Ollama catalog metadata#91248
steipete merged 1 commit into
mainfrom
fix/ollama-catalog-live-metadata

Conversation

@steipete

@steipete steipete commented Jun 7, 2026

Copy link
Copy Markdown
Contributor

Summary

Fixes #90315.

  • Pass configured provider model rows into runtime catalog augmentation so exact configured Ollama refs can be enriched from live /api/show metadata before configured metadata is overlaid.
  • Enable Ollama runtime catalog augmentation and probe configured local, remote, and Ollama Cloud refs with bounded concurrency.
  • Preserve configured provider row name/API/metadata precedence, and only attach concrete configured/resolved show-probe API keys so placeholders and ambient local OLLAMA_API_KEY are not sent as bearer tokens.

Verification

Live provider proof:

  • Reproduced the issue shape against local Ollama: POST http://127.0.0.1:11434/api/show for minimax-m3:cloud returned 200 with capabilities completion, tools, thinking, and vision.

Commands run:

  • node scripts/run-vitest.mjs extensions/ollama/index.test.ts
  • node scripts/run-vitest.mjs src/agents/model-catalog.test.ts src/plugins/providers.test.ts extensions/ollama/index.test.ts extensions/ollama/src/provider-models.test.ts
  • git diff --check && pnpm exec oxfmt --check extensions/ollama/index.ts extensions/ollama/index.test.ts extensions/ollama/src/provider-models.ts extensions/ollama/openclaw.plugin.json src/agents/model-catalog.ts src/agents/model-catalog.test.ts src/plugins/providers.test.ts
  • pnpm tsgo:extensions
  • pnpm check:test-types
  • pnpm lint:extensions
  • pnpm tsgo:core
  • pnpm lint:core
  • autoreview --mode local (clean after accepted auth findings were fixed)

@openclaw-barnacle openclaw-barnacle Bot added agents Agent runtime and tooling extensions: ollama size: XL maintainer Maintainer-authored PR labels Jun 7, 2026
@steipete

steipete commented Jun 7, 2026

Copy link
Copy Markdown
Contributor Author

Land-ready proof for #90315:

Behavior addressed:

  • Exact configured Ollama refs now pass through runtime catalog augmentation, so live /api/show metadata can fill missing reasoning/input/context/tool capability data before configured metadata remains the final overlay.
  • Configured local, remote, and Ollama Cloud refs are probed with bounded concurrency.
  • Show-probe auth uses concrete configured/resolved credentials only; non-secret placeholders and ambient local OLLAMA_API_KEY are not sent as bearer tokens.

Real environment tested:

  • Local Ollama at http://127.0.0.1:11434.

Evidence before/fix target:

  • POST http://127.0.0.1:11434/api/show for minimax-m3:cloud returned 200 with capabilities completion, tools, thinking, and vision, matching the issue’s missing gateway catalog metadata.

Exact commands run after this patch:

  • node scripts/run-vitest.mjs extensions/ollama/index.test.ts
  • node scripts/run-vitest.mjs src/agents/model-catalog.test.ts src/plugins/providers.test.ts extensions/ollama/index.test.ts extensions/ollama/src/provider-models.test.ts
  • git diff --check && pnpm exec oxfmt --check extensions/ollama/index.ts extensions/ollama/index.test.ts extensions/ollama/src/provider-models.ts extensions/ollama/openclaw.plugin.json src/agents/model-catalog.ts src/agents/model-catalog.test.ts src/plugins/providers.test.ts
  • pnpm tsgo:extensions
  • pnpm check:test-types
  • pnpm lint:extensions
  • pnpm tsgo:core
  • pnpm lint:core
  • autoreview --mode local

Observed result after fix:

  • Focused regression tests cover configured exact refs, fallback/per-agent refs, id-only and partial provider rows, bounded probe concurrency/cap, first-class Ollama Cloud refs, authenticated remote refs, secured local refs, SecretInput env strings, non-secret auth markers, configured metadata precedence, and configured API/name preservation.
  • Final autoreview was clean: no accepted/actionable findings.

What was not tested:

  • Full release validation and cross-OS provider E2E were not run for this narrow catalog/provider fix.

@clawsweeper

clawsweeper Bot commented Jun 7, 2026

Copy link
Copy Markdown
Contributor

ClawSweeper status: review started.

I am starting a fresh review of this pull request: fix: preserve live Ollama catalog metadata This is item 1/1 in the current shard. Shard 0/1.

This placeholder means the worker is alive and reading the current context. I will edit this same comment with the actual review when the claws are done clicking.

Crustacean status: shell secured, claws on keyboard, evidence pebbles being sorted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agents Agent runtime and tooling extensions: ollama maintainer Maintainer-authored PR size: XL

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Ollama Cloud live-discovered model loses capability metadata in gateway catalog

1 participant