fix: align Xiaomi completions replay compat#91113
Conversation
|
Codex review: needs real behavior proof before merge. Reviewed June 7, 2026, 3:55 AM ET / 07:55 UTC. Summary PR surface: Source +3, Tests +76. Total +79 across 2 files. Reproducibility: yes. for the source-level payload path: current main only enables provider replay injection for DeepSeek, while the sibling agent transport path already enables it for Xiaomi. A live Xiaomi 400 was not reproduced in this review. Review metrics: 1 noteworthy metric.
Merge readiness Overall follows the weaker of proof and patch quality, so missing proof can cap an otherwise strong patch. Rank-up moves:
Proof guidance:
Risk before merge
Maintainer options:
Next step before merge
Security Review detailsBest possible solution: Land the narrow compat alignment after maintainer acceptance or a redacted live Xiaomi multi-turn tool replay proves the external API path. Do we have a high-confidence way to reproduce the issue? Yes for the source-level payload path: current main only enables provider replay injection for DeepSeek, while the sibling agent transport path already enables it for Xiaomi. A live Xiaomi 400 was not reproduced in this review. Is this the best way to solve the issue? Yes, this is an acceptable narrow fix for the documented AGENTS.md: found and applied where relevant. Codex review notes: model gpt-5.5, reasoning high; reviewed against 589ea28dabc8. Label changesLabel changes:
Label justifications:
Evidence reviewedPR surface: Source +3, Tests +76. Total +79 across 2 files. View PR surface stats
What I checked:
Likely related people:
What the crustacean ranks mean
Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics. How this review workflow works
|
50c7952 to
d7d6b29
Compare
|
Land-ready proof for What changed:
External API proof:
Local verification:
CI:
What was not tested:
|
Summary
xiaomimimo.comMiMo endpoints like DeepSeek-style reasoning endpoints for assistant replayreasoning_content: ""Fixes #91106.
Verification
OPENCLAW_VITEST_MAX_WORKERS=1 node scripts/run-vitest.mjs src/llm/providers/openai-completions.test.ts src/agents/openai-completions-compat.test.ts-> 40 tests passedpnpm exec oxfmt --check --threads=1 src/llm/providers/openai-completions.ts src/llm/providers/openai-completions.test.tsnode scripts/run-oxlint.mjs --tsconfig config/tsconfig/oxlint.core.json src/llm/providers/openai-completions.ts src/llm/providers/openai-completions.test.tspnpm tsgo:coregit diff --checkpnpm changed:lanes --json-> core + coreTests only/Users/steipete/Projects/agent-scripts/skills/autoreview/scripts/autoreview --mode local-> clean, no accepted/actionable findingsAPI proof
reasoning_content, otherwise the API returns 400: https://platform.xiaomimimo.com/docs/en-US/usage-guide/passing-back-reasoning_contenthttps://api.xiaomimimo.com/v1/chat/completionsas the Xiaomi endpoint: https://platform.xiaomimimo.com/docs/en-US/api/chat/openai-api?target=request-bodyNot tested
opbuild has no search flag and I did not broadly enumerate vault contents. The after-fix regression captures the exact outbound provider payload before network dispatch.