fix(openai): accept missing content-type on ChatGPT Responses SSE stream#90533
fix(openai): accept missing content-type on ChatGPT Responses SSE stream#90533clawsweeper[bot] wants to merge 5 commits into
Conversation
|
Thanks for the context here. I did a careful shell check against current Current main already fixes the central ChatGPT Responses missing content-type failure with stream body sniffing and content-type synthesis; this replacement PR's remaining Accept-header and JSDoc/test additions are useful hygiene but no longer necessary to keep open. So I’m closing this as already implemented rather than keeping a duplicate issue open. Review detailsBest possible solution: Keep the current main body-sniffing normalization as the canonical fix and close this replacement branch as redundant hygiene rather than merging another provider-transport change. Do we have a high-confidence way to reproduce the issue? Yes for shipped behavior: the linked bug report gives a concrete v2026.6.1 probe path and logs showing HTTP 200 with an empty content-type failing as Is this the best way to solve the issue? No for keeping this PR open: the current main guard is the better canonical fix because the source PR reported that an Accept header alone did not stop the live endpoint from returning no content type. The PR's scoped Accept header is compatible hygiene, but not required to solve the remaining observable problem. Security review: Security review cleared: The PR changes scoped provider request handling tests, one request-option helper, and JSDoc only; it does not add dependencies, workflows, credentials handling, package resolution, or new code-execution paths. AGENTS.md: found and applied where relevant. What I checked:
Likely related people:
Codex review notes: model gpt-5.5, reasoning high; reviewed against e0018382eb00; fix evidence: commit 506c2ee18186, main fix timestamp 2026-06-04T22:34:53-04:00. |
|
🦞🧹
Draft PRs stay fix-only until GitHub marks them ready for review. Pause with Automerge progress:
Re-review progress:
|
f1924ad to
ecc88e1
Compare
|
ClawSweeper applied the proposed close for this PR.
|
Makes #90399 merge-ready for the ClawSweeper automerge loop.
The edit pass should inspect the live PR diff, review comments, and failing checks; rebase if needed; keep the contributor branch credited; and stop only when validation is green or an external blocker is proven.
ClawSweeper 🐠 replacement reef notes:
Inherited issue-closing references from the source PR:
Fixes #90382
Co-author credit kept:
fish notes: model gpt-5.5, reasoning high; reviewed against f1924ad.