fix: ignore canonical Windows gateway task names#90512
Conversation
|
Codex review: needs real behavior proof before merge. Reviewed June 5, 2026, 8:11 AM ET / 12:11 UTC. Summary PR surface: Source 0, Tests +29. Total +29 across 2 files. Reproducibility: yes. source inspection gives a high-confidence path: current main parses raw Review metrics: none identified. Merge readiness Overall follows the weaker of proof and patch quality, so missing proof can cap an otherwise strong patch. Rank-up moves:
Proof guidance:
Risk before merge
Maintainer options:
Next step before merge
Security Review findings
Review detailsBest possible solution: Strip root-folder prefixes, then match only canonical default/profile task names exactly and keep copy/stale tasks reported, with a focused regression and redacted Windows status/doctor proof. Do we have a high-confidence way to reproduce the issue? Yes, source inspection gives a high-confidence path: current main parses raw Is this the best way to solve the issue? No. Prefix stripping is the right direction, but applying it before the broad Full review comments:
Overall correctness: patch is incorrect AGENTS.md: found and applied where relevant. Codex review notes: model gpt-5.5, reasoning high; reviewed against afa04d6454f5. Label changesLabel changes:
Label justifications:
Evidence reviewedPR surface: Source 0, Tests +29. Total +29 across 2 files. View PR surface stats
What I checked:
Likely related people:
What the crustacean ranks mean
Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics. How this review workflow works
|
|
Nice focused fix. Small test-shape thought: the implementation now strips both leading |
Summary
Stop the Windows gateway-service detector from flagging the canonical
\OpenClaw Gatewayscheduled task as an extra service just becauseschtasksprefixes the task name with a backslash.Changes
TaskName: \OpenClaw Gatewayalongside a legacy task in the sameschtasksoutputTesting
node scripts/run-vitest.mjs run src/daemon/inspect.test.ts src/commands/doctor-gateway-services.test.ts src/cli/daemon-cli/status.print.test.tsFixes #90494