UI: send docs markdown links to public docs#89489
Conversation
|
Codex review: needs real behavior proof before merge. Reviewed June 2, 2026, 10:33 AM ET / 14:33 UTC. Summary PR surface: Source +79, Tests +39. Total +118 across 2 files. Reproducibility: yes. The current-main markdown sanitizer leaves root-relative hrefs unchanged, and the linked issue shows those docs paths resolving against the Mission Control origin instead of the public docs host; I did not run a live browser repro in this read-only review. Review metrics: none identified. Merge readiness Overall follows the weaker of proof and patch quality, so missing proof can cap an otherwise strong patch. Rank-up moves:
Proof guidance:
Mantis proof suggestion Risk before merge
Maintainer options:
Next step before merge
Security Review detailsBest possible solution: Land the shared markdown-renderer normalization after CI and real Mission Control proof confirm public docs links and preserved app/API routes. Do we have a high-confidence way to reproduce the issue? Yes. The current-main markdown sanitizer leaves root-relative hrefs unchanged, and the linked issue shows those docs paths resolving against the Mission Control origin instead of the public docs host; I did not run a live browser repro in this read-only review. Is this the best way to solve the issue? Yes. The shared sanitizer hook is the right fix boundary because chat, cron, side-result, skills, and markdown sidebar surfaces all render through AGENTS.md: found and applied where relevant. Codex review notes: model gpt-5.5, reasoning high; reviewed against c8d21fe7f05b. Label changesLabel changes:
Label justifications:
Evidence reviewedPR surface: Source +79, Tests +39. Total +118 across 2 files. View PR surface stats
What I checked:
Likely related people:
What the crustacean ranks mean
Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics. How this review workflow works
|
Summary
https://docs.openclaw.ai/..../usage,/chat, and/api/....Test Plan
node scripts/run-vitest.mjs ui/src/ui/markdown.test.ts -t "docs-root|nested docs links|markdown sidebars|keeps app-relative links navigable"node scripts/run-vitest.mjs ui/src/ui/markdown.test.ts ui/src/ui/views/cron.test.ts ui/src/ui/views/agents.test.ts ui/src/ui/views/chat.test.tspnpm checkFixes #89465
— Seraphel