Fix chrome extension bundled path resolution by kelvinCB · Pull Request #8914 · openclaw/openclaw

kelvinCB · 2026-02-04T15:56:43Z

Fixes openclaw browser extension install failing on global installs by resolving the bundled extension directory relative to dist/ (npm layout is <root>/dist, extension at <root>/assets/chrome-extension).

Update bundledExtensionRootDir() to use ../assets/chrome-extension
Adjust test to assert install succeeds using the bundled path

Tests: pnpm test src/cli/browser-cli-extension.test.ts

Greptile Overview

Greptile Summary

This PR updates Chrome extension install logic to resolve the bundled extension directory relative to the compiled dist/ output (so global/npm installs can find assets/chrome-extension), and adjusts the unit test to exercise the default bundled-path install.

The change fits into the CLI’s browser extension install command by altering the internal bundledExtensionRootDir() used when no sourceDir override is provided, ensuring installs copy from the packaged assets into the user’s state directory.

Confidence Score: 4/5

This PR is likely safe to merge; the functional change is small and targeted.
The path resolution change is straightforward and matches the described npm package layout. Main remaining concerns are test robustness (temp dir choice/cleanup and weakened assertion), which can cause flaky or messy test runs but don’t undermine the core fix.
src/cli/browser-cli-extension.test.ts (temp dir creation/cleanup and assertion strength)

_{(2/5) Greptile learns from your feedback when you react with thumbs up/down!}

greptile-apps

_{2 files reviewed, 3 comments}

_{Edit Code Review Agent Settings | Greptile}

greptile-apps · 2026-02-04T15:58:04Z

src/cli/browser-cli-extension.test.ts

+    const tmp = path.join(process.cwd(), ".tmp-test-openclaw-state", String(Date.now()));

-    const sourceDir = path.resolve(process.cwd(), "assets/chrome-extension");
-    const result = await installChromeExtension({ stateDir: tmp, sourceDir });
+    const result = await installChromeExtension({ stateDir: tmp });


[P1] Test writes to a non-unique, non-cleaned state directory

Using path.join(process.cwd(), ".tmp-test-openclaw-state", String(Date.now())) can collide in parallel test runs (same ms) and leaves artifacts in the repo if the test fails/succeeds. This makes CI flakier and can dirty local working trees. Prefer a unique temp dir via fs.mkdtempSync(os.tmpdir()) (or include PID + random) and clean it up in a finally block.

Prompt To Fix With AI

This is a comment left during a code review. Path: src/cli/browser-cli-extension.test.ts Line: 11:13 Comment: [P1] Test writes to a non-unique, non-cleaned state directory Using `path.join(process.cwd(), ".tmp-test-openclaw-state", String(Date.now()))` can collide in parallel test runs (same ms) and leaves artifacts in the repo if the test fails/succeeds. This makes CI flakier and can dirty local working trees. Prefer a unique temp dir via `fs.mkdtempSync(os.tmpdir())` (or include PID + random) and clean it up in a `finally` block. How can I resolve this? If you propose a fix, please make it concise.

greptile-apps · 2026-02-04T15:58:05Z

src/cli/browser-cli-extension.test.ts

+    expect(result.path).toContain(path.join("browser", "chrome-extension"));
    expect(fs.existsSync(path.join(result.path, "manifest.json"))).toBe(true);


[P2] Assertion is weaker than needed for the intended regression

expect(result.path).toContain(path.join("browser", "chrome-extension")) will pass even if result.path points somewhere unexpected (e.g., a longer unrelated path containing that substring). Since installChromeExtension({ stateDir: tmp }) should deterministically install to path.join(tmp, "browser", "chrome-extension"), asserting exact equality would better lock in the behavior this test cares about.

Prompt To Fix With AI

This is a comment left during a code review. Path: src/cli/browser-cli-extension.test.ts Line: 15:16 Comment: [P2] Assertion is weaker than needed for the intended regression `expect(result.path).toContain(path.join("browser", "chrome-extension"))` will pass even if `result.path` points somewhere unexpected (e.g., a longer unrelated path containing that substring). Since `installChromeExtension({ stateDir: tmp })` should deterministically install to `path.join(tmp, "browser", "chrome-extension")`, asserting exact equality would better lock in the behavior this test cares about. How can I resolve this? If you propose a fix, please make it concise.

greptile-apps · 2026-02-04T15:58:06Z

src/cli/browser-cli-extension.ts

+  // `dist/` lives at `<packageRoot>/dist` in npm installs.
+  // The bundled extension lives at `<packageRoot>/assets/chrome-extension`.
+  // So we need to go up ONE level from `dist`.
+  return path.resolve(here, "../assets/chrome-extension");


[P3] Comment claims here is dist/, but it’s a file directory

here = path.dirname(fileURLToPath(import.meta.url)) resolves to the directory containing the compiled file (e.g., <packageRoot>/dist/cli), not <packageRoot>/dist. The ../assets/... path is likely still correct, but the comment is slightly misleading and could confuse future adjustments.

Prompt To Fix With AI

This is a comment left during a code review. Path: src/cli/browser-cli-extension.ts Line: 18:21 Comment: [P3] Comment claims `here` is `dist/`, but it’s a file directory `here = path.dirname(fileURLToPath(import.meta.url))` resolves to the directory containing the compiled file (e.g., `<packageRoot>/dist/cli`), not `<packageRoot>/dist`. The `../assets/...` path is likely still correct, but the comment is slightly misleading and could confuse future adjustments. How can I resolve this? If you propose a fix, please make it concise.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: d7c26010d5

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-02-04T16:00:28Z

src/cli/browser-cli-extension.ts

 function bundledExtensionRootDir() {
  const here = path.dirname(fileURLToPath(import.meta.url));
-  return path.resolve(here, "../../assets/chrome-extension");
+
+  // `dist/` lives at `<packageRoot>/dist` in npm installs.
+  // The bundled extension lives at `<packageRoot>/assets/chrome-extension`.
+  // So we need to go up ONE level from `dist`.
+  return path.resolve(here, "../assets/chrome-extension");
 }


Restore source-tree bundled extension path fallback

The new path calculation only works when import.meta.url is inside dist/…, but in dev/test runs pnpm openclaw … executes the TypeScript from src/cli, so path.resolve(here, "../assets/chrome-extension") resolves to src/assets/chrome-extension (which doesn’t exist). That makes installChromeExtension() throw “Bundled Chrome extension is missing” for local development and tests that use the default path. Consider checking for ../assets and falling back to ../../assets when running from the source tree.

Useful? React with 👍 / 👎.

kelvinCB · 2026-02-05T07:12:28Z

Hi! First PR here in this repo🙏
All checks are green except macOS jobs which have been stuck in queued for ~12 hours (macos-app lint/build/test + checks-macos).
Could someone with admin access please re-run/unblock the macOS jobs and take a quick look?
Thanks!
@steipete @cpojer

steipete · 2026-02-05T08:17:49Z

Landed via temp rebase onto main.\n\n- Gate: pnpm lint && pnpm build && pnpm test (fails: src/auto-reply/command-control.test.ts, src/agents/pi-tools.safe-bins.test.ts, src/agents/pi-tools.workspace-paths.test.ts, src/cli/program.smoke.test.ts, src/hooks/bundled/session-memory/handler.test.ts)\n- Land commit: 63ec16f\n- Merge commit: 1ee1522\n\nThanks @kelvinCB!

openclaw-barnacle bot added the cli CLI command changes label Feb 4, 2026

greptile-apps bot reviewed Feb 4, 2026

View reviewed changes

chatgpt-codex-connector bot reviewed Feb 4, 2026

View reviewed changes

kelvinCB mentioned this pull request Feb 4, 2026

[Bug]: openclaw browser extension install fails: bundled extension path resolves outside package #8905

Closed

kelvinCB mentioned this pull request Feb 5, 2026

fix(cli): correct bundled Chrome extension path #9449

Closed

matthewpoe mentioned this pull request Feb 7, 2026

Bug: Bundled hooks broken on npm global install (Linux) — path resolution + missing handler files #11331

Closed

github-actions bot mentioned this pull request Feb 8, 2026

cherry-pick: upstream bugfix commits (2026-02-08) hughdidit/DAISy-Agency#109

Closed

6 tasks

github-actions bot mentioned this pull request Feb 8, 2026

cherry-pick: upstream bugfix commits (2026-02-08-2013) hughdidit/DAISy-Agency#117

Merged

6 tasks

kilhyeonjun mentioned this pull request Feb 22, 2026

[Bug]: Builtin extension .ts source files stripped during npm global install — gateway fails to start #23439

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fix chrome extension bundled path resolution#8914

Fix chrome extension bundled path resolution#8914
steipete merged 5 commits intoopenclaw:mainfrom
kelvinCB:fix/chrome-extension-install-path

kelvinCB commented Feb 4, 2026 •

edited by greptile-apps bot

Loading

Uh oh!

greptile-apps bot left a comment

Uh oh!

greptile-apps bot Feb 4, 2026

Uh oh!

greptile-apps bot Feb 4, 2026

Uh oh!

greptile-apps bot Feb 4, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Uh oh!

chatgpt-codex-connector bot Feb 4, 2026

Uh oh!

kelvinCB commented Feb 5, 2026

Uh oh!

steipete commented Feb 5, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

		expect(result.path).toContain(path.join("browser", "chrome-extension"));
		expect(fs.existsSync(path.join(result.path, "manifest.json"))).toBe(true);

Uh oh!

Conversation

kelvinCB commented Feb 4, 2026 • edited by greptile-apps bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Greptile Overview

Greptile Summary

Confidence Score: 4/5

Uh oh!

greptile-apps bot left a comment

Choose a reason for hiding this comment

Uh oh!

greptile-apps bot Feb 4, 2026

Choose a reason for hiding this comment

Uh oh!

greptile-apps bot Feb 4, 2026

Choose a reason for hiding this comment

Uh oh!

greptile-apps bot Feb 4, 2026

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector bot Feb 4, 2026

Choose a reason for hiding this comment

Uh oh!

kelvinCB commented Feb 5, 2026

Uh oh!

steipete commented Feb 5, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

kelvinCB commented Feb 4, 2026 •

edited by greptile-apps bot

Loading