fix(discord): balance truncated progress italics#88900
fix(discord): balance truncated progress italics#88900charles-openclaw wants to merge 2 commits into
Conversation
|
Codex review: needs real behavior proof before merge. Reviewed June 1, 2026, 12:09 AM ET / 04:09 UTC. Summary PR surface: Source +18, Tests +48. Total +66 across 2 files. Reproducibility: yes. from source inspection, though I did not run a live Discord guild repro in this read-only review. Discord commentary is underscore-wrapped before shared progress-line compaction, and current main only rebalances backticks after truncation. Review metrics: none identified. Merge readiness Overall follows the weaker of proof and patch quality, so missing proof can cap an otherwise strong patch. Rank-up moves:
Proof guidance:
Mantis proof suggestion Risk before merge
Maintainer options:
Next step before merge
Security Review detailsBest possible solution: Land the shared formatter repair after redacted live Discord progress-draft proof confirms truncated commentary no longer renders a literal leading underscore. Do we have a high-confidence way to reproduce the issue? Yes from source inspection, though I did not run a live Discord guild repro in this read-only review. Discord commentary is underscore-wrapped before shared progress-line compaction, and current main only rebalances backticks after truncation. Is this the best way to solve the issue? Yes, this is the narrow maintainable fix path: repair the shared compaction boundary where the invalid Markdown is created and cover the important underscore cases. The remaining blocker is proof of the real Discord draft behavior after the patch. AGENTS.md: found and applied where relevant. Codex review notes: model gpt-5.5, reasoning high; reviewed against 3b802a7fbc5a. Label changesLabel justifications:
Evidence reviewedPR surface: Source +18, Tests +48. Total +66 across 2 files. View PR surface stats
What I checked:
Likely related people:
What the crustacean ranks mean
Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics. How this review workflow works
|
|
Follow-up pushed in Summary:
Verification:
Still not live-tested in a Discord guild; this remains local formatter coverage from the contributor environment. @clawsweeper re-review |
|
🦞🧹 I asked ClawSweeper to review this item again. Re-review progress:
|
|
This PR fixes the behavior I described in the original issue. After (commit e8170be): This PR fixes the previous broken behavior (literal leading _ printing when the trailling _ was truncated) while preserving the italics in the non-truncated thinking. @charles-openclaw feel free to include in your original post and ask clawsweeper to re-review. |



Summary
Linked context
Closes #88895.
Real behavior proof (required for external PRs)
streaming.mode: "progress"commentary could render_Checking...literally when line compaction removed the closing_.src/plugin-sdk/channel-streaming.test.ts.Checking whether the Discord progress draft keeps markdown…, without a leading_.Tests and validation
corepack pnpm exec oxfmt --write --threads=1 src/channels/streaming.ts src/plugin-sdk/channel-streaming.test.tsPNPM_CONFIG_OFFLINE=true corepack pnpm test src/plugin-sdk/channel-streaming.test.ts -- --reporter=dotpassed 1 Vitest shard / 29 tests.git diff --check -- src/channels/streaming.ts src/plugin-sdk/channel-streaming.test.tsRisk checklist
_, which matches the broken italic-commentary shape.Current review state
Ready for maintainer review; no live Discord proof is available from this contributor environment.