fix(feishu): send full streaming card content#88871
Conversation
|
Codex review: needs real behavior proof before merge. Reviewed May 31, 2026, 10:33 PM ET / 02:33 UTC. Summary PR surface: Source -1, Tests 0. Total -1 across 2 files. Reproducibility: yes. at source level: current main slices Feishu CardKit updates down to suffixes while the official streaming-card guide describes sending full text and letting the platform compute the visible increment. I did not run a live Feishu/Lark tenant reproduction in this read-only review. Review metrics: 1 noteworthy metric.
Merge readiness Overall follows the weaker of proof and patch quality, so missing proof can cap an otherwise strong patch. Rank-up moves:
Proof guidance:
Risk before merge
Maintainer options:
Next step before merge
Security Review detailsBest possible solution: Land the focused payload fix after a credentialed Feishu/Lark streaming-card smoke test or an explicit maintainer proof override, then let the linked bug close through the merged PR. Do we have a high-confidence way to reproduce the issue? Yes at source level: current main slices Feishu CardKit updates down to suffixes while the official streaming-card guide describes sending full text and letting the platform compute the visible increment. I did not run a live Feishu/Lark tenant reproduction in this read-only review. Is this the best way to solve the issue? Yes, this is the narrowest maintainable fix I found: the changed helper is the single payload decision point before updateCardContent, and the replace path for final rewrites remains separate. The remaining gap is live external proof, not a better code location. AGENTS.md: found and applied where relevant. Codex review notes: model gpt-5.5, reasoning high; reviewed against 4932391e8a78. Label changesLabel changes:
Label justifications:
Evidence reviewedPR surface: Source -1, Tests 0. Total -1 across 2 files. View PR surface stats
What I checked:
Likely related people:
What the crustacean ranks mean
Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics. How this review workflow works
|
|
Tested on real Feishu environment - v2026.5.26 and v2026.6.1 both have this issue. Streaming cards only show the last character. This fix is needed across all versions. Please merge. |
Live environment evidence (helps clear
|
Summary
Linked context
Closes #88867.
Real behavior proof (required for external PRs)
PNPM_CONFIG_OFFLINE=true corepack pnpm test extensions/feishu/src/streaming-card.test.ts -- --reporter=dot.hello small,hello!,hello world, andhello world!as complete card content.Tests and validation
PNPM_CONFIG_OFFLINE=true corepack pnpm test extensions/feishu/src/streaming-card.test.ts -- --reporter=dotgit diff --checkRisk checklist
Current review state
Ready for review. Live Feishu proof still needs maintainer-side or credentialed tenant validation.