fix(memory): retry transient embedding failures#88599
Merged
Merged
Conversation
Contributor
|
ClawSweeper status: review started. I am starting a fresh review of this pull request: fix(memory): retry transient embedding failures This is item 1/1 in the current shard. Shard 0/1. This placeholder means the worker is alive and reading the current context. I will edit this same comment with the actual review when the claws are done clicking. Crustacean status: shell secured, claws on keyboard, evidence pebbles being sorted. |
This was referenced May 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #71784
Fixes #44166
Supersedes #44167
Verification
node scripts/run-vitest.mjs extensions/memory-core/src/memory/manager-embedding-policy.test.ts extensions/memory-core/src/memory/index.test.tspassed, 34 tests.env -u OPENCLAW_TESTBOX pnpm check:changedpassed..agents/skills/autoreview/scripts/autoreview --mode localclean.Real behavior proof
Behavior addressed:
memory_searchand memory reindex no longer fail immediately on transient embedding socket failures.Real environment tested: local OpenClaw source checkout with mocked memory-core embedding providers.
Exact steps or command run after this patch:
node scripts/run-vitest.mjs extensions/memory-core/src/memory/manager-embedding-policy.test.ts extensions/memory-core/src/memory/index.test.ts;env -u OPENCLAW_TESTBOX pnpm check:changed;.agents/skills/autoreview/scripts/autoreview --mode local.Evidence after fix: focused Vitest passed 34 tests; changed gate passed; autoreview reported no accepted/actionable findings.
Observed result after fix: query embeddings retry after
fetch failed | other side closed; exhausted splittable batch socket failures split recursively and preserve embedding order;ECONNREFUSED, unreachable hosts, service throttles, and manager batch timeouts do not split.What was not tested: live external embedding provider outage behavior; coverage uses deterministic mocked provider failures.