fix(doctor): quiet tool policy removal audits#88100
Conversation
|
Codex review: needs maintainer review before merge. Reviewed May 31, 2026, 7:30 PM ET / 23:30 UTC. Summary PR surface: Source +17, Tests +40. Total +57 across 9 files. Reproducibility: yes. Current main source shows removal audits emitted at info level from the shared policy pipeline, and the linked report gives a concrete doctor run with tools.profile set to coding; I did not rerun doctor because this review was read-only. Review metrics: none identified. Merge readiness Overall follows the weaker of proof and patch quality, so missing proof can cap an otherwise strong patch. Next step before merge
Security Review detailsBest possible solution: Land the narrow doctor-only debug override after normal maintainer review so routine doctor probes stay quiet while actionable runtime and sandbox policy audits remain visible. Do we have a high-confidence way to reproduce the issue? Yes. Current main source shows removal audits emitted at info level from the shared policy pipeline, and the linked report gives a concrete doctor run with tools.profile set to coding; I did not rerun doctor because this review was read-only. Is this the best way to solve the issue? Yes. The branch is the best narrow fix because it adds an internal diagnostic log-level override only for doctor probe paths instead of globally lowering all policy-removal audits or suppressing actionable sandbox policy blocks. AGENTS.md: found and applied where relevant. Codex review notes: model gpt-5.5, reasoning high; reviewed against db7aff884361. Label changesLabel justifications:
Evidence reviewedPR surface: Source +17, Tests +40. Total +57 across 9 files. View PR surface stats
What I checked:
Likely related people:
What the crustacean ranks mean
Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics. How this review workflow works
|
|
@clawsweeper re-review Removed the CHANGELOG.md entry per the rank-up feedback. Net PR diff is now only src/agents/tool-policy-audit.ts and src/agents/tool-policy-pipeline.test.ts. Local follow-up checks after the cleanup: git diff --check passed; oxfmt --check passed on touched source/test files. |
|
🦞🧹 I asked ClawSweeper to review this item again. Re-review progress:
|
7a67af5 to
ac457b5
Compare
ac457b5 to
d7063e7
Compare
|
Land-ready proof for
|
1 similar comment
|
Land-ready proof for
|
Summary
infolevel by default.debugso expected profile filtering does not pollute normalopenclaw doctoroutput.info.Fixes #87798.
Validation
node scripts/run-vitest.mjs src/agents/tool-policy-pipeline.test.ts src/flows/doctor-core-checks.runtime.test.ts src/flows/doctor-core-checks.runtime-errors.test.ts src/commands/doctor/shared/active-tool-schema-warnings.test.tsnode scripts/run-vitest.mjs ui/src/ui/views/chat.test.ts src/agents/agent-bundle-mcp-runtime.test.tsnode scripts/test-projects.mjs test/vitest/vitest.gateway-methods.config.tsOPENCLAW_VITEST_INCLUDE_FILE=/tmp/agent-chat-include.json node scripts/test-projects.mjs test/vitest/vitest.gateway-server.config.tspnpm lint --threads=8git diff --checknode node_modules/oxfmt/bin/oxfmt --check ...on touched filespnpm exec oxlint ...on touched files.agents/skills/autoreview/scripts/autoreview --mode branch --base origin/mainCI
b7af1f56ec1638298fd01258c098e2d079f1851dSurface Area