fix(tui): prewarm agent runtime before first send#86981
Conversation
1036441 to
961a0f6
Compare
e5a588e to
aaa2bb9
Compare
|
Codex review: found issues before merge. Reviewed May 29, 2026, 1:18 AM ET / 05:18 UTC. Summary PR surface: Source +56, Tests +52. Total +108 across 6 files. Reproducibility: yes. for the review finding: source inspection shows the PR's new Review metrics: 2 noteworthy metrics.
Merge readiness Overall follows the weaker of proof and patch quality, so missing proof can cap an otherwise strong patch. Rank-up moves:
Risk before merge
Maintainer options:
Next step before merge
Security Review findings
Review detailsBest possible solution: Land this only after the generic harness prewarm hook exists on the target branch and the real TUI submit path passes or otherwise enforces the warmup busy state with focused TUI proof. Do we have a high-confidence way to reproduce the issue? Yes for the review finding: source inspection shows the PR's new Is this the best way to solve the issue? No. The prewarm direction is plausible, but the current diff does not wire the submit gate through the real caller and depends on a closed unmerged base hook. Full review comments:
Overall correctness: patch is incorrect AGENTS.md: found and applied where relevant. Codex review notes: model gpt-5.5, reasoning high; reviewed against 309fdd95dad5. Label changesLabel changes:
Label justifications:
Evidence reviewedPR surface: Source +56, Tests +52. Total +108 across 6 files. View PR surface stats
What I checked:
Likely related people:
What the crustacean ranks mean
Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics. How this review workflow works
|
|
ClawSweeper PR egg 🔥 Warming up: real-behavior proof passed; findings, security review, or rank-up moves are still in progress. Hatch commandComment Hatchability rules:
What is this egg doing here?
|
This comment was marked as spam.
This comment was marked as spam.
|
Closing as underlying stacked PR was closed and #90782 is alternative |
Summary
warming runtimeand block submit until the warmup settles.Verification
git diff --check origin/maingit diff --check fix/harness-runtime-prewarm..HEADnode scripts/test-projects-serial.mjs src/agents/harness/prewarm.test.ts src/tui/tui-session-actions.test.ts src/tui/tui.test.tsnode scripts/run-vitest.mjs run --config test/vitest/vitest.extension-codex.config.ts extensions/codex/index.test.tsStack
Stacked on #86930. This PR contains only the TUI consumer wiring for the generic harness prewarm hook.