fix: use configured baseUrl for Ollama model discovery by koushikkethamakka · Pull Request #8693 · openclaw/openclaw

koushikkethamakka · 2026-02-04T08:51:22Z

Summary

Previously, discoverOllamaModels() used a hardcoded localhost URL (http://127.0.0.1:11434) regardless of user configuration. This caused model discovery to fail silently for remote Ollama instances, even when the user had correctly configured models.providers.ollama.baseUrl.

Changes

discoverOllamaModels() now accepts optional baseUrl parameter
buildOllamaProvider() passes configured baseUrl to discovery
resolveImplicitProviders() receives config and extracts Ollama baseUrl
Strips /v1 suffix from baseUrl when calling /api/tags endpoint

Testing

Existing tests pass
Tested with remote Ollama configuration

Before

# Config
models.providers.ollama.baseUrl: "http://remote-server:11434/v1"

# Discovery always hits localhost, fails
GET http://127.0.0.1:11434/api/tags → timeout/error

After

# Config  
models.providers.ollama.baseUrl: "http://remote-server:11434/v1"

# Discovery uses configured URL (with /v1 stripped)
GET http://remote-server:11434/api/tags → success

Greptile Overview

Greptile Summary

This PR threads the configured models.providers.ollama.baseUrl through provider resolution so Ollama model discovery (/api/tags) no longer always targets http://127.0.0.1:11434. It adds a baseUrl? parameter to discoverOllamaModels, passes config down from ensureOpenClawModelsJson to resolveImplicitProviders, and normalizes configured URLs by stripping a trailing /v1 when calling the Ollama-native discovery endpoint.

Overall it aligns implicit provider generation with user configuration, which fits the existing pattern where other providers (e.g., Copilot/Bedrock) accept config/env input during implicit resolution.

Confidence Score: 4/5

This PR is likely safe to merge and fixes the intended remote Ollama discovery behavior.
Changes are localized (provider resolution + discovery URL) and preserve existing defaults, but URL normalization is a bit ad-hoc and could produce awkward URLs or misleading logs in some configurations.
src/agents/models-config.providers.ts (Ollama URL normalization and discovery logging)

_{(2/5) Greptile learns from your feedback when you react with thumbs up/down!}

greptile-apps

_{1 file reviewed, 2 comments}

_{Edit Code Review Agent Settings | Greptile}

greptile-apps · 2026-02-04T08:52:55Z

src/agents/models-config.providers.ts

+  const baseUrl = configuredBaseUrl ?? OLLAMA_BASE_URL;
+  const apiBaseUrl = baseUrl.replace(/\/v1\/?$/, "");
+  const models = await discoverOllamaModels(apiBaseUrl);


The /v1 stripping only removes an exact trailing /v1 or /v1/, but it won’t handle common variants like http://host:11434/v1/api (should probably stay intact) or http://host:11434/v1/ with extra whitespace, and it doesn’t normalize trailing slashes (can lead to //api/tags). Consider normalizing via new URL() and explicitly joining paths so discovery always hits exactly <root>/api/tags.

(If you want to keep regex-based logic, it may also be worth trimming and then removing a trailing / after the replacement.)

Prompt To Fix With AI

This is a comment left during a code review. Path: src/agents/models-config.providers.ts Line: 392:394 Comment: The `/v1` stripping only removes an exact trailing `/v1` or `/v1/`, but it won’t handle common variants like `http://host:11434/v1/api` (should probably stay intact) or `http://host:11434/v1/` with extra whitespace, and it doesn’t normalize trailing slashes (can lead to `//api/tags`). Consider normalizing via `new URL()` and explicitly joining paths so discovery always hits exactly `<root>/api/tags`. (If you want to keep regex-based logic, it may also be worth trimming and then removing a trailing `/` after the replacement.) How can I resolve this? If you propose a fix, please make it concise.

greptile-apps · 2026-02-04T08:52:56Z

Additional Comments (1)

src/agents/models-config.providers.ts
discoverOllamaModels always says "local instance" when data.models is empty, but this function now supports remote instances via baseUrl (see apiBaseUrl on src/agents/models-config.providers.ts:99). This log message will be misleading in the common remote-config case.

      console.warn("No Ollama models found on configured instance");

Prompt To Fix With AI

This is a comment left during a code review.
Path: src/agents/models-config.providers.ts
Line: 109:111

Comment:
`discoverOllamaModels` always says "local instance" when `data.models` is empty, but this function now supports remote instances via `baseUrl` (see `apiBaseUrl` on `src/agents/models-config.providers.ts:99`). This log message will be misleading in the common remote-config case.

```suggestion
      console.warn("No Ollama models found on configured instance");
```

How can I resolve this? If you propose a fix, please make it concise.

Previously, discoverOllamaModels() used a hardcoded localhost URL (http://127.0.0.1:11434) regardless of user configuration. This caused model discovery to fail silently for remote Ollama instances, even when the user had correctly configured models.providers.ollama.baseUrl. Changes: - discoverOllamaModels() now accepts optional baseUrl parameter - buildOllamaProvider() passes configured baseUrl to discovery - resolveImplicitProviders() receives config and extracts Ollama baseUrl - Strips /v1 suffix from baseUrl when calling /api/tags endpoint Fixes openclaw#8663

mattmiddlesworth · 2026-02-12T16:42:31Z

This might fix my issue where I'm unable to connect to my remote Ollama farm

danitt · 2026-02-13T02:00:41Z

just adding my support here - this 100% addressed my connectivity issue with VM Openclaw + local Ollama

thanks @koushikkethamakka for putting this up

sebslight · 2026-02-13T03:48:44Z

Closing as duplicate of #10742. If this is incorrect, comment and we can reopen.

vincentkoc · 2026-02-27T23:22:47Z

Merged in #29201

openclaw-barnacle bot added the agents Agent runtime and tooling label Feb 4, 2026

greptile-apps bot reviewed Feb 4, 2026

View reviewed changes

koushikkethamakka force-pushed the fix/ollama-discovery-baseurl branch from 6276363 to b0640c3 Compare February 4, 2026 08:55

hillct mentioned this pull request Feb 6, 2026

Feature/remote ollama - enable autodiscovery ollama models on hosts other than localhost #10742

Closed

sebslight closed this Feb 13, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix: use configured baseUrl for Ollama model discovery#8693

fix: use configured baseUrl for Ollama model discovery#8693
koushikkethamakka wants to merge 1 commit intoopenclaw:mainfrom
koushikkethamakka:fix/ollama-discovery-baseurl

koushikkethamakka commented Feb 4, 2026 •

edited by greptile-apps bot

Loading

Uh oh!

greptile-apps bot left a comment

Uh oh!

greptile-apps bot Feb 4, 2026

Uh oh!

greptile-apps bot commented Feb 4, 2026

Uh oh!

mattmiddlesworth commented Feb 12, 2026

Uh oh!

danitt commented Feb 13, 2026

Uh oh!

sebslight commented Feb 13, 2026

Uh oh!

vincentkoc commented Feb 27, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

Conversation

koushikkethamakka commented Feb 4, 2026 • edited by greptile-apps bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Changes

Testing

Before

After

Greptile Overview

Greptile Summary

Confidence Score: 4/5

Uh oh!

greptile-apps bot left a comment

Choose a reason for hiding this comment

Uh oh!

greptile-apps bot Feb 4, 2026

Choose a reason for hiding this comment

Uh oh!

greptile-apps bot commented Feb 4, 2026

Uh oh!

mattmiddlesworth commented Feb 12, 2026

Uh oh!

danitt commented Feb 13, 2026

Uh oh!

sebslight commented Feb 13, 2026

Uh oh!

vincentkoc commented Feb 27, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

koushikkethamakka commented Feb 4, 2026 •

edited by greptile-apps bot

Loading