Fix isolated cron cold runner setup timeout#86893
Open
dredozubov wants to merge 1 commit into
Open
Conversation
Contributor
|
Codex review: needs real behavior proof before merge. Reviewed May 29, 2026, 1:14 AM ET / 05:14 UTC. Summary PR surface: Source +8, Tests +66. Total +74 across 2 files. Reproducibility: unclear. The review failed before ClawSweeper could establish a reproduction path. Review metrics: none identified. Merge readiness Overall follows the weaker of proof and patch quality, so missing proof can cap an otherwise strong patch. Risk before merge
Maintainer options:
Next step before merge
Review detailsBest possible solution: Retry the Codex review after fixing the execution failure. Do we have a high-confidence way to reproduce the issue? Unclear. The review failed before ClawSweeper could establish a reproduction path. Is this the best way to solve the issue? Unclear. Retry the review first so ClawSweeper can evaluate the actual issue and fix direction. AGENTS.md: unclear because the file could not be read completely. Codex review notes: model gpt-5.5, reasoning high; reviewed against 8eb5ff08c86b. Label changesLabel changes:
Label justifications:
Evidence reviewedPR surface: Source +8, Tests +66. Total +74 across 2 files. View PR surface stats
What I checked:
Likely related people:
What the crustacean ranks mean
Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics. How this review workflow works
|
Contributor
|
ClawSweeper PR egg: ✨ hatched ✨ glimmer Cosmic Shellbean. Rarity: ✨ glimmer. Trait: polishes edge cases. DetailsShare on X: post this hatch
About:
|
634e73c to
2c96985
Compare
Author
|
@clawsweeper re-review |
Contributor
|
🦞🧹 I asked ClawSweeper to review this item again. Re-review progress:
|
2c96985 to
e864cf5
Compare
This was referenced May 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Tests
node scripts/run-vitest.mjs src/cron/service/timer.regression.test.tsReal behavior proof
Behavior addressed: isolated cron agent-turn setup no longer aborts at the old fixed 60s runner-start watchdog when the job has a longer timeout budget; the run stays alive past 60s and then reaches the new bounded setup timeout.
Real environment tested: local OpenClaw cron runtime on PR head
2c969858b6389c7e3e056c1a5e51ab894868bc6b, macOS, Node 26.0.0, isolated temp cron store, no external credentials or network services.Exact steps or command run after this patch: ran a real-time
node --import tsx --input-type=modulescript from the PR checkout that instantiatedCronService, created an isolatedagentTurncron job withtimeoutSeconds: 130, started a manual run, withheld the runner-start signal, sampled state after 61s, then let cron reach the derived setup bound.Evidence after fix: copied terminal output from the real-time cron runtime run:
{ "openclawHead": "2c969858b6389c7e3e056c1a5e51ab894868bc6b", "scenario": "isolated cron agent-turn waits before runner start", "configuredTimeoutSeconds": 130, "expectedPatchedSetupBoundMs": 65000, "after61s": { "elapsedMs": 61035, "runnerHookEnteredMs": 41, "abortObserved": false, "cleanupCalls": 0 }, "final": { "elapsedMs": 65067, "abortObservedAtMs": 65044, "cleanupCalls": 1, "cleanupTimeoutMs": 130000, "runResult": { "ok": true, "ran": true }, "lastRunStatus": "error", "lastStatus": "error", "lastError": "cron: isolated agent setup timed out before runner start", "persistedJobs": 1 }, "events": [ { "action": "started", "elapsedMs": 34, "jobId": "2ddaca0a-a12e-4b7c-b7d9-2ab0746ee121" }, { "elapsedMs": 65061, "level": "warn", "message": "cron: job run returned error status", "payload": { "jobId": "2ddaca0a-a12e-4b7c-b7d9-2ab0746ee121", "jobName": "PR 86893 live setup-window proof", "error": "cron: isolated agent setup timed out before runner start", "diagnosticsSummary": "cron: isolated agent setup timed out before runner start" } }, { "action": "finished", "elapsedMs": 65062, "jobId": "2ddaca0a-a12e-4b7c-b7d9-2ab0746ee121", "status": "error", "error": "cron: isolated agent setup timed out before runner start", "durationMs": 65014 } ] }Observed result after fix: at 61.035s cron had not aborted and cleanup had not run; at about 65.044s cron aborted the pre-runner setup phase and recorded
cron: isolated agent setup timed out before runner start, matching the patched derived bound for a 130s isolated job instead of the previous fixed 60s abort.What was not tested: a full external Codex provider cold start with live model credentials was not run; this proof isolates the cron watchdog path before runner start, which is the changed runtime behavior.