fix(codex): route node exec through OpenClaw tools#85417
Conversation
|
Verification note: the green GitHub Keeping this draft until a real node-routing proof is attached or run: /exec host=node node=<mac-node> security=full ask=off
uname -s && hostname && pwd && whoamiExpected: the visible shell reports the selected macOS node environment, including |
|
Codex review: needs maintainer review before merge. Latest ClawSweeper review: 2026-05-22 15:19 UTC / May 22, 2026, 11:19 AM ET. Workflow note: Future ClawSweeper reviews update this same comment in place. How this review workflow works
Summary Reproducibility: yes. source-reproducible: current main receives session PR rating Rank-up moves:
What the crustacean ranks mean
Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics. Real behavior proof Risk before merge
Maintainer options:
Next step before merge Security Review detailsBest possible solution: Keep this PR open and land it only after live node-routing proof is attached or maintainers explicitly accept the compatibility and command-routing risk for node-targeted Codex app-server sessions. Do we have a high-confidence way to reproduce the issue? Yes, source-reproducible: current main receives session Is this the best way to solve the issue? Yes, the proposed direction is the narrowest owner-boundary fix: disable the native Codex shell only when the effective OpenClaw exec host is Label changes:
Label justifications:
Acceptance criteria:
What I checked:
Likely related people:
Codex review notes: model gpt-5.5, reasoning high; reviewed against 8fc48af09190. |
|
ClawSweeper PR egg ✨ Hatched: 🥚 common Tiny Clawlet Hatch commandComment Hatchability rules:
Rarity: 🥚 common. What is this egg doing here?
|
Summary
node.execandprocessdynamic tools for node-targeted Codex app-server runs so shell commands route through the selected node.Root Cause
/exec host=nodeupdated the OpenClaw exec defaults, but Codex app-server native shell remained enabled and still executed in the app-server/gateway environment. The node-aware OpenClawexecpath was present, but Codex could bypass it through its native shell surface.Validation
git diff --check origin/mainnode scripts/run-vitest.mjs extensions/codex/src/app-server/run-attempt.test.ts(206 passed)codex review --base origin/main(no actionable regressions)Blocked in this shell:
Follow-up Proof Required Before Merge
Run a real Linux gateway/container plus connected macOS node proof:
Expected result: the visible shell command reports the selected macOS node environment, including
Darwin, not the Linux gateway/container.Fixes #85012.
Supersedes #85090.