fix(codex): expose bound conversation dynamic tools#85213
fix(codex): expose bound conversation dynamic tools#85213wizdomhall-hash wants to merge 1 commit into
Conversation
|
Codex review: needs real behavior proof before merge. Workflow note: Future ClawSweeper reviews update this same comment in place. How this review workflow works
Summary Reproducibility: yes. source inspection gives a high-confidence reproduction path: current main handles app-server conversation PR rating Rank-up moves:
What the crustacean ranks mean
Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics. Real behavior proof Risk before merge
Maintainer options:
Next step before merge Security Review findings
Review detailsBest possible solution: Keep the Codex conversation dynamic-tool bridge, but preserve the existing plugin tool allowlist contract and require redacted after-fix proof from a real AgentOS/Codex setup before merge. Do we have a high-confidence way to reproduce the issue? Yes, source inspection gives a high-confidence reproduction path: current main handles app-server conversation Is this the best way to solve the issue? No, not as written: the bridge implementation is plausible, but the shared plugin discovery change breaks the existing Label changes:
Label justifications:
Full review comments:
Overall correctness: patch is incorrect What I checked:
Likely related people:
Codex review notes: model gpt-5.5, reasoning high; reviewed against 229490a48924. |
|
ClawSweeper PR egg 🎁 Pass real behavior proof to wake the egg and unlock a hatchable treat. Where did the egg go?
|
Summary
Motivation
On macOS, the Kynver AgentOS OpenClaw plugin could be loaded and runtime inspection could see its
agent_os_*contracts, but native Codex conversation threads did not receive those dynamic tool specs as callable tools. That meantagent_os_get_contextand related tools were visible to OpenClaw inspection but missing from the Codex-visible tool surface.This PR recovers the working local Track 2 patch from a macOS OpenClaw/Codex install where the AgentOS tools became callable after the Codex bridge change.
Before / After
Before:
After:
Verification
Focused tests run in the prepared recovery checkout:
Result:
Additional checks:
git diff --cached --check -- .The same whitespace check passed again after replaying the patch onto a fresh
openclaw/openclawclone. The fresh clone did not have dependencies installed, so the focused test command there stopped at missingvitest/package.jsonbefore tests started.MacOS smoke from the patched local setup:
agent_os_get_contextScope
The patch is limited to the Codex conversation binding / dynamic tool bridge and supporting plugin registry behavior needed for that path. No secrets or local machine paths are included.