Skip to content

fix(models): respect auth order in picker label#83691

Closed
clawsweeper[bot] wants to merge 4 commits into
mainfrom
clawsweeper/automerge-openclaw-openclaw-83581
Closed

fix(models): respect auth order in picker label#83691
clawsweeper[bot] wants to merge 4 commits into
mainfrom
clawsweeper/automerge-openclaw-openclaw-83581

Conversation

@clawsweeper

@clawsweeper clawsweeper Bot commented May 18, 2026

Copy link
Copy Markdown
Contributor

Makes #83581 merge-ready for the ClawSweeper automerge loop.
The edit pass should inspect the live PR diff, review comments, and failing checks; rebase if needed; keep the contributor branch credited; and stop only when validation is green or an external blocker is proven.
Known failing checks:

ClawSweeper 🐠 replacement reef notes:

  • Repair fallback: GitHub rejected the repair branch push because it updates workflow files and the ClawSweeper app token does not have workflows permission

Co-author credit kept:

fish notes: model gpt-5.5, reasoning high; reviewed against c6d9e29.

@clawsweeper clawsweeper Bot added size: S clawsweeper:automerge Maintainer opted this PR into bounded ClawSweeper-reviewed automerge proof: override Maintainer override for the external PR real behavior proof gate. mantis: telegram-visible-proof Mantis should capture Telegram visible proof. P2 Normal backlog priority with limited blast radius. rating: 🦐 gold shrimp Decent PR readiness signal, but merge confidence is limited. merge-risk: 🚨 auth-provider 🚨 May break OAuth, tokens, provider routing, model choice, or credentials. status: 🚀 automerge armed This PR is in ClawSweeper's automerge lane. clawsweeper Tracked by ClawSweeper automation labels May 18, 2026
@clawsweeper

clawsweeper Bot commented May 18, 2026

Copy link
Copy Markdown
Contributor Author

Thanks for the context here. I swept through the related work, and this is now duplicate or superseded.

Close as superseded because a newer open PR now owns the same /models OpenAI/Codex auth-label fix, directly links the original issue, has its own proof thread, and is already in the maintainer-requested automerge path.

Canonical path: Use #83697 as the canonical fix for #83574 and close this duplicate replacement PR to avoid two automerge branches racing.

So I’m closing this here and keeping the remaining discussion on #83697 and #83574.

Review details

Best possible solution:

Use #83697 as the canonical fix for #83574 and close this duplicate replacement PR to avoid two automerge branches racing.

Do we have a high-confidence way to reproduce the issue?

Yes, source-level. Current main still calls the picker auth-label resolver without the effective OpenAI/Codex accepted-provider set, and both open PRs target that same path.

Is this the best way to solve the issue?

No, this is no longer the best branch to carry the fix. The maintainable path is to land or close the newer canonical PR that directly references the original issue and already has proof/automerge context.

Security review:

Security review cleared: The diff is limited to auth-label display plumbing, tests, and changelog text; I found no concrete security or supply-chain regression.

What I checked:

Likely related people:

  • steipete: Merged PR metadata shows this account authored the OpenAI PI auth-order work touching model-auth-label, openai-codex-routing, status labeling, and related tests that this picker-label fix reuses. (role: current implementation introducer and recent area contributor; confidence: high; commits: 8267492f27d9, a2b614a30b75; files: src/agents/model-auth-label.ts, src/agents/openai-codex-routing.ts, src/status/status-text.ts)
  • Tak Hoffman: Git history shows recent model-picker/provider endpoint fixes by this person, and the live related threads show this account requested automerge for the replacement/canonical fix path. (role: recent model-picker contributor and automerge requester; confidence: medium; commits: ae2b1aef10c4, 67fba9c5e173; files: src/auto-reply/reply/commands-models.ts)
  • Vincent Koc: Local history shows recent Telegram callback and model-picker maintenance in the affected visible channel area, useful if maintainers want a Telegram-specific follow-up review. (role: recent Telegram/model-picker adjacent contributor; confidence: medium; commits: a7ac3c666c4e, 88111453cb76, 438991b6a430; files: extensions/telegram/src/bot-handlers.runtime.ts, src/auto-reply/reply/commands-models.ts)

Codex review notes: model gpt-5.5, reasoning high; reviewed against 06a39015f21c.

@clawsweeper clawsweeper Bot temporarily deployed to qa-live-shared May 18, 2026 16:44 Inactive
@openclaw-mantis

Copy link
Copy Markdown

Mantis Telegram Desktop Proof

Summary: Mantis captured native Telegram Desktop before/after GIFs showing the /models openai auth label change.

Main screenshot This PR screenshot
Baseline native Telegram Desktop screenshot Candidate native Telegram Desktop screenshot
Main This PR
Baseline native Telegram Desktop proof GIF Candidate native Telegram Desktop proof GIF

Motion-trimmed clips:

Raw QA files: https://artifacts.openclaw.ai/mantis/telegram-desktop/pr-83691/run-26047082046-1/index.json

@clawsweeper

clawsweeper Bot commented May 18, 2026

Copy link
Copy Markdown
Contributor Author

ClawSweeper applied the proposed close for this PR.

@clawsweeper clawsweeper Bot closed this May 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

clawsweeper:automerge Maintainer opted this PR into bounded ClawSweeper-reviewed automerge clawsweeper Tracked by ClawSweeper automation mantis: telegram-visible-proof Mantis should capture Telegram visible proof. merge-risk: 🚨 auth-provider 🚨 May break OAuth, tokens, provider routing, model choice, or credentials. P2 Normal backlog priority with limited blast radius. proof: override Maintainer override for the external PR real behavior proof gate. rating: 🦐 gold shrimp Decent PR readiness signal, but merge confidence is limited. size: S status: 🚀 automerge armed This PR is in ClawSweeper's automerge lane.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants