fix: reconcile subagent wait timeouts#82888
Merged
Merged
Conversation
Contributor
|
ClawSweeper status: review started. I am starting a fresh review of this pull request: fix: reconcile subagent wait timeouts This is item 1/1 in the current shard. Shard 0/1. This placeholder means the worker is alive and reading the current context. I will edit this same comment with the actual review when the claws are done clicking. Crustacean status: shell secured, claws on keyboard, evidence pebbles being sorted. |
36d9eff to
e32ddd8
Compare
e32ddd8 to
2c32315
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #82787.
Verification
Real behavior proof
Behavior addressed: parent subagent waiters no longer record a terminal timeout when agent.wait only hit its poll timeout and the child session is still running.
Real environment tested: local OpenClaw checkout plus Blacksmith Testbox changed-check environment for the touched runtime surface.
Exact steps or command run after this patch: focused subagent registry/session-spawn Vitest command, CodexReview, git diff --check, and pnpm check:changed in Testbox tbx_01krt1rxpkb7vj53mkaqwfserq.
Evidence after fix: terminal output from the rebased focused run and remote Testbox run:
Observed result after fix: the unsettled child-session timeout, terminal wait timeout, stale terminal row rejection, and terminal session-store reconciliation regressions pass; changed-check completed with exit 0 in Testbox.
What was not tested: live Discord/Telegram provider roundtrip with a real delayed subagent; covered with registry/session-spawn e2e simulation and Testbox checks instead.