fix(gateway): land linked diagnostics fixes#82690
Merged
Merged
Conversation
Co-authored-by: Mil Wang <mingjwan@microsoft.com>
Co-authored-by: Andy Ye <35905412+TurboTheTurtle@users.noreply.github.com>
This was referenced May 16, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #66832.
Fixes #79108.
Supersedes #67041.
Supersedes #79233.
Verification
git diff --checknode scripts/run-vitest.mjs src/logging/redact.test.ts src/logging/log-tail-redaction.test.ts src/gateway/call.test.ts src/commands/health.test.ts src/cli/gateway-cli.coverage.test.ts src/cli/devices-cli.test.ts -- --reporter=dotnode scripts/crabbox-wrapper.mjs run --provider blacksmith-testbox --blacksmith-org openclaw --blacksmith-workflow .github/workflows/ci-check-testbox.yml --blacksmith-job check --blacksmith-ref main --idle-timeout 90m --ttl 240m --timing-json -- CI=1 NODE_OPTIONS=--max-old-space-size=4096 OPENCLAW_TEST_PROJECTS_PARALLEL=6 OPENCLAW_VITEST_MAX_WORKERS=1 OPENCLAW_VITEST_NO_OUTPUT_TIMEOUT_MS=900000 OPENCLAW_TESTBOX=1 OPENCLAW_TESTBOX_REMOTE_RUN=1 pnpm check:changedReal behavior proof
Behavior addressed: logs.tail no longer returns raw Basic auth or named gateway/security header credentials; JSON-mode health/gateway health/devices list commands emit structured gateway_transport_error payloads for typed Gateway close/timeout failures instead of plain text errors.
Real environment tested: focused local Vitest through
scripts/run-vitest.mjs; Blacksmith Testbox through Crabbox providerblacksmith-testbox.Exact steps or command run after this patch: the Verification commands above, after rebasing onto
origin/main.Evidence after fix: focused tests passed 8 files / 348 tests; Testbox
tbx_01krryzqc6djxxnbrpea1n3n0t, Actions run https://github.com/openclaw/openclaw/actions/runs/25968977106, exited 0.Observed result after fix: redaction assertions remove raw fixture credentials from log-tail output, and CLI JSON assertions receive
ok:falsegateway_transport_error payloads without stderr fallback.What was not tested: live gateway network failure against a real daemon; the code paths are covered with typed transport-error unit/CLI tests plus changed-gate lint/type/import-cycle checks.