Skip to content

fix(gateway): land linked diagnostics fixes#82690

Merged
vincentkoc merged 2 commits into
mainfrom
impact/linked-gateway-items
May 16, 2026
Merged

fix(gateway): land linked diagnostics fixes#82690
vincentkoc merged 2 commits into
mainfrom
impact/linked-gateway-items

Conversation

@vincentkoc

Copy link
Copy Markdown
Member

Summary

Fixes #66832.
Fixes #79108.
Supersedes #67041.
Supersedes #79233.

Verification

  • git diff --check
  • node scripts/run-vitest.mjs src/logging/redact.test.ts src/logging/log-tail-redaction.test.ts src/gateway/call.test.ts src/commands/health.test.ts src/cli/gateway-cli.coverage.test.ts src/cli/devices-cli.test.ts -- --reporter=dot
  • node scripts/crabbox-wrapper.mjs run --provider blacksmith-testbox --blacksmith-org openclaw --blacksmith-workflow .github/workflows/ci-check-testbox.yml --blacksmith-job check --blacksmith-ref main --idle-timeout 90m --ttl 240m --timing-json -- CI=1 NODE_OPTIONS=--max-old-space-size=4096 OPENCLAW_TEST_PROJECTS_PARALLEL=6 OPENCLAW_VITEST_MAX_WORKERS=1 OPENCLAW_VITEST_NO_OUTPUT_TIMEOUT_MS=900000 OPENCLAW_TESTBOX=1 OPENCLAW_TESTBOX_REMOTE_RUN=1 pnpm check:changed

Real behavior proof

Behavior addressed: logs.tail no longer returns raw Basic auth or named gateway/security header credentials; JSON-mode health/gateway health/devices list commands emit structured gateway_transport_error payloads for typed Gateway close/timeout failures instead of plain text errors.
Real environment tested: focused local Vitest through scripts/run-vitest.mjs; Blacksmith Testbox through Crabbox provider blacksmith-testbox.
Exact steps or command run after this patch: the Verification commands above, after rebasing onto origin/main.
Evidence after fix: focused tests passed 8 files / 348 tests; Testbox tbx_01krryzqc6djxxnbrpea1n3n0t, Actions run https://github.com/openclaw/openclaw/actions/runs/25968977106, exited 0.
Observed result after fix: redaction assertions remove raw fixture credentials from log-tail output, and CLI JSON assertions receive ok:false gateway_transport_error payloads without stderr fallback.
What was not tested: live gateway network failure against a real daemon; the code paths are covered with typed transport-error unit/CLI tests plus changed-gate lint/type/import-cycle checks.

vincentkoc and others added 2 commits May 17, 2026 02:00
Co-authored-by: Mil Wang <mingjwan@microsoft.com>
Co-authored-by: Andy Ye <35905412+TurboTheTurtle@users.noreply.github.com>
@openclaw-barnacle openclaw-barnacle Bot added gateway Gateway runtime cli CLI command changes commands Command implementations size: M labels May 16, 2026
@vincentkoc vincentkoc marked this pull request as ready for review May 16, 2026 18:04
@openclaw-barnacle openclaw-barnacle Bot added the maintainer Maintainer-authored PR label May 16, 2026
@vincentkoc vincentkoc merged commit e06782d into main May 16, 2026
70 of 74 checks passed
@vincentkoc vincentkoc deleted the impact/linked-gateway-items branch May 16, 2026 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cli CLI command changes commands Command implementations gateway Gateway runtime maintainer Maintainer-authored PR size: M

Projects

None yet

1 participant