Closed
Conversation
Contributor
Author
|
Superseded by main commit 48ff229, which fixes the same MS Teams lifecycle test type errors. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
never[]/empty mock call tuples.Verification
pnpm tsgo:test:extensionspnpm test extensions/msteams/src/monitor.lifecycle.test.tsReal behavior proof
Behavior or issue addressed: current PR merge refs fail
check-test-typesonextensions/msteams/src/monitor.lifecycle.test.tsbecause the test mocks infernever[]and empty call tuples.Real environment tested: clean local worktree at current
origin/mainwith repository dependencies linked from the main checkout.Exact steps or command run after this patch:
pnpm tsgo:test:extensionsandpnpm test extensions/msteams/src/monitor.lifecycle.test.ts.Evidence after fix:
pnpm tsgo:test:extensionsexited 0;pnpm test extensions/msteams/src/monitor.lifecycle.test.tsreportedTest Files 1 passed (1)andTests 5 passed (5).Observed result after fix: the previously failing MS Teams lifecycle test type errors are gone and the targeted runtime test still passes.
What was not tested: full repository CI has not completed yet.