Skip to content

test(msteams): fix lifecycle test types#79257

Closed
steipete wants to merge 1 commit intomainfrom
fix/msteams-lifecycle-test-types
Closed

test(msteams): fix lifecycle test types#79257
steipete wants to merge 1 commit intomainfrom
fix/msteams-lifecycle-test-types

Conversation

@steipete
Copy link
Copy Markdown
Contributor

@steipete steipete commented May 8, 2026

Summary

  • Type the MS Teams lifecycle test mocks so the extension test typecheck lane no longer infers never[]/empty mock call tuples.
  • Keep runtime test behavior unchanged.

Verification

  • pnpm tsgo:test:extensions
  • pnpm test extensions/msteams/src/monitor.lifecycle.test.ts

Real behavior proof

Behavior or issue addressed: current PR merge refs fail check-test-types on extensions/msteams/src/monitor.lifecycle.test.ts because the test mocks infer never[] and empty call tuples.

Real environment tested: clean local worktree at current origin/main with repository dependencies linked from the main checkout.

Exact steps or command run after this patch: pnpm tsgo:test:extensions and pnpm test extensions/msteams/src/monitor.lifecycle.test.ts.

Evidence after fix: pnpm tsgo:test:extensions exited 0; pnpm test extensions/msteams/src/monitor.lifecycle.test.ts reported Test Files 1 passed (1) and Tests 5 passed (5).

Observed result after fix: the previously failing MS Teams lifecycle test type errors are gone and the targeted runtime test still passes.

What was not tested: full repository CI has not completed yet.

@steipete
Copy link
Copy Markdown
Contributor Author

steipete commented May 8, 2026

Superseded by main commit 48ff229, which fixes the same MS Teams lifecycle test type errors.

@steipete steipete closed this May 8, 2026
@openclaw-barnacle openclaw-barnacle Bot added channel: msteams Channel integration: msteams size: XS maintainer Maintainer-authored PR labels May 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

channel: msteams Channel integration: msteams maintainer Maintainer-authored PR size: XS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant