fix(plugins): avoid managed npm prefix on Windows#78902
Conversation
|
Codex review: needs maintainer review before merge. Summary Reproducibility: yes. Current main still runs managed-root npm commands with both Real behavior proof Next step before merge Security Review detailsBest possible solution: Finish maintainer review, undraft when ready, let the normal required checks run, and land the narrow argv/docs/tests/changelog fix for #78514. Do we have a high-confidence way to reproduce the issue? Yes. Current main still runs managed-root npm commands with both Is this the best way to solve the issue? Yes. Removing Acceptance criteria:
What I checked:
Likely related people:
Remaining risk / open question:
Codex review notes: model gpt-5.5, reasoning high; reviewed against af49c09d1320. |
d9125e9 to
d23b670
Compare
|
Maintainer draft-prep update:
Prepared draft head pushed: |
Summary
--prefix ..Verification
pnpm exec oxfmt --check --threads=1 src/plugins/install.ts src/plugins/uninstall.ts src/infra/npm-managed-root.ts src/plugins/install.npm-spec.test.ts src/plugins/uninstall.test.ts src/infra/npm-managed-root.test.tspnpm test:serial src/infra/npm-managed-root.test.ts src/plugins/install.npm-spec.test.ts src/plugins/uninstall.test.ts--prefix .reproducedCannot read properties of undefined (reading 'spec'), and the same cwd/env without--prefix .passed (run_f663e2eda151,cbx_a2c8c093a232).OPENCLAW_TESTBOX=1 OPENCLAW_TESTBOX_ID=tbx_01kr0xjkgxg4606zahffgq1cjg pnpm check:changed(GitHub Actions run: https://github.com/openclaw/openclaw/actions/runs/25488666774)git diff --check origin/main...HEAD