Conversation
dc1d571 to
d2145d9
Compare
|
Codex review: found issues before merge. Summary Reproducibility: yes. Source inspection on current main shows Android still rejects private-LAN cleartext setup/manual endpoints and persists bootstrap handoff tokens only for loopback or TLS; I did not run a live device repro in this read-only review. Real behavior proof Next step before merge Security Review findings
Review detailsBest possible solution: Land a rebased, maintainer-reviewed Android policy patch with security-doc alignment and live mobile pairing proof, then close the superseded draft PR if this one replaces it. Do we have a high-confidence way to reproduce the issue? Yes. Source inspection on current main shows Android still rejects private-LAN cleartext setup/manual endpoints and persists bootstrap handoff tokens only for loopback or TLS; I did not run a live device repro in this read-only review. Is this the best way to solve the issue? Mostly yes, but not merge-ready. The code direction matches the remaining Android gap while preserving public and tailnet cleartext rejection, but the security-guide conflict and live mobile proof gap should be resolved before merge. Full review comments:
Overall correctness: patch is incorrect Security concerns:
Acceptance criteria:
What I checked:
Likely related people:
Remaining risk / open question:
Codex review notes: model gpt-5.5, reasoning high; reviewed against 7dc597b92176. Re-review progress:
|
Summary
origin/mainws://pairing/auth for private LAN, link-local, ULA,.local, loopback, and emulator routes while continuing to reject public/Tailscale cleartext routesVerification
git diff --cached --checkbefore commitpnpm check:changedswift test --package-path apps/shared/OpenClawKit --filter 'DeepLinksSecurityTests|GatewayNodeSessionTests'Local verification limitation
/usr/libexec/java_homereports no runtime). The Android tests from the recreated change are included and should run in CI:cd apps/android && ./gradlew :app:testPlayDebugUnitTest --tests ai.openclaw.app.gateway.GatewaySessionInvokeTest.bootstrapHandoffPersistenceTrustsPrivateLanCleartextEndpoints --tests ai.openclaw.app.ui.GatewayConfigResolverTest --tests ai.openclaw.app.node.ConnectionManagerTestSupersedes draft PR #78140, which had unverified/conflicted commits.