fix: stabilize Matrix tool progress QA#78179
Conversation
|
Codex review: needs changes before merge. Summary Reproducibility: yes. source-level: current main can reject shortened bare-backtick Matrix tool-progress-error previews because that scenario lacks the generic preview-line fallback. I did not run the live Matrix lane locally in this read-only review. Real behavior proof Next step before merge Security Review findings
Review detailsBest possible solution: Add the required Matrix changelog entry, let current-head QA-Lab and maintainer handling finish, then land if checks stay green. Do we have a high-confidence way to reproduce the issue? Yes, source-level: current main can reject shortened bare-backtick Matrix tool-progress-error previews because that scenario lacks the generic preview-line fallback. I did not run the live Matrix lane locally in this read-only review. Is this the best way to solve the issue? Mostly yes: the PR keeps the matcher, approval wait, and retry changes narrow to Matrix/QA behavior, and the earlier prepareTarget contract issue is fixed. The remaining safer path is a small changelog-only repair plus maintainer review before merge. Full review comments:
Overall correctness: patch is correct Acceptance criteria:
What I checked:
Likely related people:
Remaining risk / open question:
Codex review notes: model gpt-5.5, reasoning high; reviewed against 627b0073f2f7. |
Summary:
Real behavior proof
Verification: