fix: handle localized schtasks access denied fallback#78171
fix: handle localized schtasks access denied fallback#78171BradGroux merged 1 commit intoopenclaw:mainfrom
Conversation
|
Codex review: needs maintainer review before merge. Summary Reproducibility: yes. by source inspection and linked runtime logs. On current main, Spanish Real behavior proof Next step before merge Security Review detailsBest possible solution: Land this narrow matcher, regression test, and changelog entry, then close #77993 and reconcile #78006 as superseded or as a separate broader-locale follow-up. Do we have a high-confidence way to reproduce the issue? Yes by source inspection and linked runtime logs. On current main, Spanish Is this the best way to solve the issue? Yes. Updating the shared fallback predicate and adding focused regression coverage is the narrowest maintainable fix for the reported Spanish-locale denial path. What I checked:
Likely related people:
Remaining risk / open question:
Codex review notes: model gpt-5.5, reasoning high; reviewed against f531eff6292e. Re-review progress:
|
|
Addressed the follow-up I could handle from this side:
The remaining ClawSweeper blocker is still the real after-fix Windows proof from the reporter/contributor environment. I can't generate that from this macOS checkout, so once we have a screenshot/log from the affected Spanish-localized Windows setup I'll update the PR body with it. |
|
Maintainer prep update:
Verification run locally:
I did not fold that unrelated agents test fix into this Windows daemon PR so this branch stays scoped to #77993. |
|
Maintainer refresh update:
Verification run locally on the refreshed head:
The previous |
|
Merged with squash after maintainer prep and green CI.\n\nPrepared head: |
Summary
schtasksaccess-denied output (Acceso denegado) as the same recoverable denial as EnglishAccess is denied.Fixes #77993
Verification
pnpm exec oxfmt --write --threads=1 src/daemon/schtasks.ts src/daemon/schtasks.startup-fallback.test.ts CHANGELOG.mdpnpm test src/daemon/schtasks.startup-fallback.test.tsgit diff --check