fix(plugins): honor allowlist for bundled provider discovery#77569
fix(plugins): honor allowlist for bundled provider discovery#77569
Conversation
Closes #75575 Co-authored-by: dougbtv <dosmith@redhat.com>
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f5e2ef4562
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| const allowedPluginIds = new Set( | ||
| allow.map((pluginId) => normalizePluginId(pluginId)).filter(Boolean), | ||
| ); | ||
| return pluginIds.filter((pluginId) => allowedPluginIds.has(pluginId)); |
There was a problem hiding this comment.
Honor disabled bundled web-provider entries
When a bundled web-search/fetch plugin is still present in plugins.allow but the operator disables it with plugins.entries.<id>.enabled=false or blocks it with plugins.deny, this public-artifact fast path still returns the plugin because it filters only against the allowlist. Since callers return these artifact providers before invoking the normal loader/manifest policy, an explicitly disabled or denied bundled web provider can still be discovered at runtime in the new allowlist mode; the filter needs to apply the same base policy as provider discovery, not just plugins.allow.
Useful? React with 👍 / 👎.
Summary
mainplugins.bundledDiscoveryso bundled provider discovery defaults toplugins.allowcompatmode plus doctor/config migration help for legacy configsVerification
pnpm test src/agents/models-config.providers.plugin-allowlist-compat.test.ts src/plugins/providers.test.ts src/plugins/web-provider-public-artifacts.fallback.test.ts src/commands/doctor-state-integrity.test.tsOPENCLAW_VITEST_SHARD_NAME=agentic-commands-doctor ... pnpm exec node scripts/test-projects.mjs test/vitest/vitest.commands.config.tspnpm lintpnpm config:schema:checkpnpm exec oxfmt --check --threads=1 src/commands/doctor-state-integrity.test.tsgit diff --check origin/main...HEADReplaces #77194.
Closes #75575.