[codex] Queue subagent completion announces#76927
Conversation
|
Codex review: needs maintainer review before merge. Summary Reproducibility: yes. Source inspection gives a high-confidence reproduction path: current main sends completion announces direct-first and retries Next step before merge Security Review detailsBest possible solution: Undraft after maintainer review, rerun current-head changed/targeted validation, then merge the queue-first completion announce path if checks remain green. Do we have a high-confidence way to reproduce the issue? Yes. Source inspection gives a high-confidence reproduction path: current main sends completion announces direct-first and retries Is this the best way to solve the issue? Yes. The PR uses existing queue/steer and fallback machinery rather than adding a new routing system, but it still needs maintainer review and current-head validation before merge. What I checked:
Likely related people:
Remaining risk / open question:
Codex review notes: model gpt-5.5, reasoning high; reviewed against 990f931a2efc. Re-review progress:
|
d3fc201 to
f9eb7d9
Compare
Summary
Root Cause
Completion-mode announces were direct-first and used synchronous
gateway agentcalls withexpectFinal, so a busy or stuck requester session could leave direct announce turns waiting behind active work and trigger repeated 120s timeout retries.Validation
pnpm test src/agents/subagent-announce-dispatch.test.ts src/agents/subagent-announce-delivery.test.ts src/agents/subagent-announce.format.e2e.test.ts src/agents/subagent-announce.timeout.test.ts src/agents/subagent-registry-lifecycle.test.tspnpm exec oxfmt --check --threads=1 src/agents/subagent-announce-dispatch.ts src/agents/subagent-announce-dispatch.test.ts src/agents/subagent-announce-delivery.ts src/agents/subagent-announce-delivery.test.ts src/agents/subagent-announce.format.e2e.test.ts src/agents/subagent-announce.timeout.test.ts src/agents/subagent-registry-lifecycle.test.tsgit diff --checkpnpm check:changed: https://github.com/openclaw/openclaw/actions/runs/25289933276