fix(plugins): include selected context-engine plugin at startup#76669
Closed
steipete wants to merge 3 commits into
Closed
fix(plugins): include selected context-engine plugin at startup#76669steipete wants to merge 3 commits into
steipete wants to merge 3 commits into
Conversation
…76598) `resolvePluginTools` returned an empty tool list when no pre-warmed channel/active registry was found after startup — the on-demand fallback removed by PR #76004 was only added back for memory and capability-provider surfaces, leaving path-based (origin "config") plugin tool factories silent. Fix: when `resolvePluginToolRegistry` returns null, trigger a standalone registry load via `ensureStandaloneRuntimePluginRegistryLoaded`, then retry. Adds regression test asserting tools are resolved without pre-warming. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…startup (#76576) External context-engine plugins (e.g. lossless-claw) register via api.registerContextEngine at load time but ship without activation.onStartup in their manifest. The gateway startup planner only considered memory plugins and explicit sidecar plugins, so a selected non-legacy context engine was omitted from the startup load plan and never loaded before agent turns resolved the active engine, producing the "Context engine X is not registered; falling back to default engine legacy" warning. Fix: add resolveContextEngineSlotStartupPluginId mirroring the memory slot pattern; pass contextEngineSlotStartupPluginId into shouldConsiderForGatewayStartup so the selected context-engine plugin is included in pluginIds regardless of its manifest activation shape. Tests: added four regression cases covering include, exclude, legacy bypass, and id normalization. 82 tests pass. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.