Fix TUI exit after gateway disconnect#75381
Fix TUI exit after gateway disconnect#75381udaymanish6 wants to merge 2 commits intoopenclaw:mainfrom
Conversation
|
Codex review: needs changes before merge. Summary Reproducibility: yes. The linked issue gives concrete gateway-restart steps, and current main still has matching code gaps in disconnected Ctrl+C handling and shutdown fallback behavior. Next step before merge Security Review findings
Review detailsBest possible solution: Land the focused TUI lifecycle fix with a single-line active-version Fixes changelog entry, keeping the runtime surface limited to the TUI shutdown path. Do we have a high-confidence way to reproduce the issue? Yes. The linked issue gives concrete gateway-restart steps, and current main still has matching code gaps in disconnected Ctrl+C handling and shutdown fallback behavior. Is this the best way to solve the issue? Yes, with one mechanical policy gap. The runtime diff is narrow and fits the reported TUI hang; it needs the required changelog entry before merge. Full review comments:
Overall correctness: patch is correct Acceptance criteria:
What I checked:
Likely related people:
Remaining risk / open question:
Codex review notes: model gpt-5.5, reasoning high; reviewed against 9fff2b779159. |
Summary
Validation
pnpm install --frozen-lockfilepnpm exec vitest run src/tui/tui.test.tsFixes #75379