fix(control-ui): disable refresh during active runs#74819
Closed
Angfr95 wants to merge 1 commit intoopenclaw:mainfrom
Closed
fix(control-ui): disable refresh during active runs#74819Angfr95 wants to merge 1 commit intoopenclaw:mainfrom
Angfr95 wants to merge 1 commit intoopenclaw:mainfrom
Conversation
The refresh button was only guarded by chatLoading and connected state, allowing clicks during active agent turns. This could stall the run, reset chat state, and wedge the gateway. Add chatSending, chatRunId, and chatStream guards to match the existing busy-state pattern used by the model and thinking selects. Fixes openclaw#65522
Contributor
|
Thanks for the context here. I swept through the related work, and this is now duplicate or superseded. Close as superseded: this branch is the same UI-only refresh guard previously reviewed on #66395, while open maintainer PR #74690 is the canonical path for the same bug and adds the browser render coverage this PR body describes. So I’m closing this here and keeping the remaining discussion on the canonical linked item. Review detailsBest possible solution: Keep #74690 as the canonical implementation path, land its UI guard plus browser disabled-state matrix if CI is acceptable, and let that merge close #65522. Security review: Security review cleared: The diff only changes a Lit disabled binding for a Control UI button and introduces no dependency, workflow, permission, secret, network, or code-execution surface. What I checked:
Likely related people:
Codex review notes: model gpt-5.5, reasoning high; reviewed against 5c46ccba0b50. |
25 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
refreshDisabledas a named variable inui/src/ui/app-render.helpers.ts, combining!connected,chatLoading,chatSending,Boolean(chatRunId), andchatStream !== nullui/src/ui/app-render.helpers.browser.test.tscovering: idle, loading, sending, active run, active stream, and disconnected statesLinked Issues
Change Type
Scope
Security Impact
🤖 Generated with Claude Code