fix(update): skip disabled plugins during post-update sync#73902
fix(update): skip disabled plugins during post-update sync#73902openclaw-clownfish[bot] wants to merge 1 commit into
Conversation
Greptile SummaryThis PR adds Confidence Score: 5/5This PR is safe to merge; the change is narrow, fail-safe, and comprehensively tested. Only a new optional flag is introduced; the default path (flag omitted/false) is entirely unchanged, and the new code path is covered by parameterized tests for all three install sources plus a regression test confirming enabled-plugin failures remain fatal. No files require special attention. Reviews (2): Last reviewed commit: "fix(update): skip disabled plugins durin..." | Re-trigger Greptile |
|
Codex review: keeping this open for maintainer follow-up; there is still a little grit to resolve. Keep this PR open. Current main still lacks the disabled-plugin skip during post-update plugin sync, and the proposed change is a focused implementation candidate for #73880 rather than obsolete work. Best possible solution: Keep this PR open and review/validate it as the focused fix for #73880. The best path is to land a narrow change that skips explicitly disabled tracked installs only during post-update sync, preserves disabled install metadata and package-id migration behavior, and keeps enabled plugin failures and integrity drift fail-closed. What I checked:
Likely related people:
Remaining risk / open question:
Codex review notes: model gpt-5.5, reasoning high; reviewed against 28ff82dcdae7. |
ff1e828 to
3aecc28
Compare
|
Closing this PR because the author has more than 10 active PRs in this repo. Please reduce the active PR queue and reopen or resubmit once it is back under the limit. You can close your own PRs to get back under the limit. |
|
Closing this PR because the author has more than 10 active PRs in this repo. Please reduce the active PR queue and reopen or resubmit once it is back under the limit. You can close your own PRs to get back under the limit. |
|
Reopening now that Barnacle no longer applies active-PR-limit closure to clownfish PRs. L3.1 still owns the actual PR closeout. |
|
Barnacle mainline fix landed: active-PR-limit closure no longer applies to clownfish PRs. I tried to reopen this PR, but GitHub rejects reopen because the |
|
Barnacle now skips the active-PR-limit label/closure path for clownfish PRs. Reopening for L3.1 follow-up; not merging here. |
Fixes #73880.
This PR updates post-update plugin sync so tracked installs that are explicitly disabled in config are resolved before any ClawHub/npm/marketplace update request and are reported as skipped or non-fatal. Enabled plugin update failures, integrity drift, and real install/update errors remain fail-closed.
Preserve disabled install metadata and package-id migration behavior; do not delete disabled installs or lose config. Keep docs unchanged unless the existing CLI update text must explicitly mention disabled tracked plugins.
Credit: report by @islandpreneur007 in #73880.
Validation plan:
ProjectClownfish replacement details: