Skip to content

fix(nvidia): align NIM provider metadata#73733

Merged
vincentkoc merged 1 commit into
mainfrom
l3/nemoclaw-roadmap-cluster-20260428
Apr 28, 2026
Merged

fix(nvidia): align NIM provider metadata#73733
vincentkoc merged 1 commit into
mainfrom
l3/nemoclaw-roadmap-cluster-20260428

Conversation

@vincentkoc

Copy link
Copy Markdown
Member

Summary

  • Persist the NVIDIA provider API-key marker in generated provider catalog output.
  • Mark bundled NVIDIA OpenAI-compatible models as string-content compatible so subagent calls send plain text content where NIM expects it.
  • Add NVIDIA catalog regression coverage and changelog credit for the related reports/PRs.

Fixes #73013
Fixes #50107
Refs #73014

Validation

  • Testbox tbx_01kqamwt8mcmmeck6g1bay8xhg: OPENCLAW_TESTBOX=1 pnpm test:serial extensions/nvidia/provider-catalog.test.ts src/agents/model-ref-shared.test.ts passed 2 Vitest shards.
  • Testbox tbx_01kqamwt8mcmmeck6g1bay8xhg: OPENCLAW_TESTBOX=1 pnpm check:changed passed.
  • Rebase sanity after clean rebase onto origin/main: git status --short --branch, git diff --check origin/main...HEAD, git diff --stat origin/main...HEAD.

@vincentkoc vincentkoc self-assigned this Apr 28, 2026
@vincentkoc vincentkoc marked this pull request as ready for review April 28, 2026 18:30
@vincentkoc vincentkoc merged commit dcd665c into main Apr 28, 2026
43 of 44 checks passed
@vincentkoc vincentkoc deleted the l3/nemoclaw-roadmap-cluster-20260428 branch April 28, 2026 18:31
@greptile-apps

greptile-apps Bot commented Apr 28, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR fixes two gaps in the bundled NVIDIA/NIM provider catalog: it persists the NVIDIA_API_KEY marker in the generated ModelProviderConfig (previously omitted because buildManifestModelProviderConfig never emitted apiKey), and marks all four bundled NIM models with compat.requiresStringContent: true so OpenAI-compatible subagent calls send plain-text content. Both changes are covered by new assertions in the provider-catalog test.

Confidence Score: 5/5

This PR is safe to merge — both fixes are targeted, consistent with codebase patterns, and covered by new regression tests.

No logic errors, security issues, or missing edge cases found. The apiKey marker value matches what the existing nvidia auth tests expect. The requiresStringContent flag is a valid field in ModelCompatConfig, and buildManifestCatalogModel already handles compat propagation. The spread ordering is correct since buildManifestModelProviderConfig never emits apiKey.

No files require special attention.

Reviews (1): Last reviewed commit: "fix(nvidia): align NIM provider metadata" | Re-trigger Greptile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

1 participant