Skip to content

test(gateway): keep session event suite minimal#73302

Merged
vincentkoc merged 1 commit intomainfrom
investigate/gateway-session-events-hotspot
Apr 28, 2026
Merged

test(gateway): keep session event suite minimal#73302
vincentkoc merged 1 commit intomainfrom
investigate/gateway-session-events-hotspot

Conversation

@vincentkoc
Copy link
Copy Markdown
Member

Summary

  • let session-message websocket tests use the default minimal gateway harness
  • avoid full gateway startup for subscription/event routing coverage

Tests

  • pnpm exec oxfmt --check --threads=1 src/gateway/session-message-events.test.ts
  • Testbox tbx_01kq98y29y9kwzkpft0sr3qg2x: pnpm test:serial src/gateway/session-message-events.test.ts --reporter=verbose
  • Testbox tbx_01kq98y29y9kwzkpft0sr3qg2x: pnpm check:changed

Perf

  • targeted file on Testbox: 6.78s / 1,157,516 KB before
  • targeted file on Testbox: 2.76s / 919,316 KB after

@openclaw-barnacle openclaw-barnacle Bot added the gateway Gateway runtime label Apr 28, 2026
@vincentkoc vincentkoc self-assigned this Apr 28, 2026
@openclaw-barnacle openclaw-barnacle Bot added size: XS maintainer Maintainer-authored PR labels Apr 28, 2026
@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps Bot commented Apr 28, 2026

Greptile Summary

This PR removes the env-var save/delete/restore boilerplate from session-message-events.test.ts that was previously forcing a full gateway startup by deleting OPENCLAW_TEST_MINIMAL_GATEWAY before each suite run. Now the suite inherits the default minimal harness (set by applyGatewaySkipEnv() via installGatewayTestHooks), which is sufficient for all tests in the file since they only exercise WebSocket subscription filtering and session transcript event routing — none of which require the full gateway subsystems (channels, providers, cron, canvas, etc.).

Confidence Score: 5/5

Safe to merge — the removed code was an explicit override to disable minimal mode; dropping it correctly re-enables the default minimal harness that all tests here actually need.

No logic errors or regressions. The deleted lines were only save/restore env-var boilerplate that forced a heavier startup, and the remaining tests are fully self-consistent under the minimal gateway.

No files require special attention.

Reviews (1): Last reviewed commit: "test(gateway): keep session event suite ..." | Re-trigger Greptile

@vincentkoc vincentkoc merged commit 27e3130 into main Apr 28, 2026
65 of 68 checks passed
@vincentkoc vincentkoc deleted the investigate/gateway-session-events-hotspot branch April 28, 2026 05:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gateway Gateway runtime maintainer Maintainer-authored PR size: XS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant