Greptile Summary

This PR fixes a bug where an exec update could emit an empty text content block when both session.tail/session.aggregated and any accumulated warnings were empty. The fix extracts a renderExecUpdateText helper that substitutes a "(no output)" placeholder for a falsy tailText, and adds three unit tests covering the main cases.

Confidence Score: 5/5

Safe to merge — minimal, well-scoped change with correct logic and good test coverage.

The change is small, the extracted function is straightforward, and the three added tests cover the targeted fix. Only a missing test for the warnings + non-empty tailText combination was found, which is a low-risk P2 gap.

No files require special attention.

This is a comment left during a code review.
Path: src/agents/bash-tools.exec-runtime.test.ts
Line: 316-337

Comment:
**Missing test for warnings + non-empty output**

The current test matrix covers three of four input combinations for `renderExecUpdateText`. The case where both `tailText` is non-empty and `warnings` is non-empty is untested, leaving the concatenation path (`warningText + tailText`) without a regression guard.

```suggestion
describe("renderExecUpdateText", () => {
  it("uses a non-empty placeholder when an exec update has no output", () => {
    expect(renderExecUpdateText({ tailText: "", warnings: [] })).toBe("(no output)");
  });

  it("preserves non-empty exec output", () => {
    expect(renderExecUpdateText({ tailText: "hello", warnings: [] })).toBe("hello");
  });

  it("keeps warnings while still avoiding empty output text", () => {
    expect(renderExecUpdateText({ tailText: "", warnings: ["Warning: retrying"] })).toBe(
      "Warning: retrying\n\n(no output)",
    );
  });

  it("combines warnings with non-empty output", () => {
    expect(renderExecUpdateText({ tailText: "hello", warnings: ["Warning: retrying"] })).toBe(
      "Warning: retrying\n\nhello",
    );
  });
});
```

How can I resolve this? If you propose a fix, please make it concise.

_{Reviews (1): Last reviewed commit: "fix(exec): avoid empty update text block..." | Re-trigger Greptile}

Addressed the Greptile suggestion in src/agents/bash-tools.exec-runtime.test.ts by adding coverage for the missing warnings + non-empty output case.

The new assertion verifies renderExecUpdateText({ tailText: "hello", warnings: ["Warning: retrying"] }) renders Warning: retrying\n\nhello, so all four combinations are now covered:

• no warnings + empty output
• no warnings + non-empty output
• warnings + empty output
• warnings + non-empty output

Validation after the change:

• targeted bash-tools.exec-runtime.test.ts passed
• pnpm check:test-types passed

Resolved.