Greptile Summary

This PR moves the resolveGatewayProbeAuthSafeWithSecretInputs regression test from the resolveGatewayProbeAuthSafe describe block into its correct matching resolveGatewayProbeAuthSafeWithSecretInputs describe block. The test body is identical — only its placement changes.

Confidence Score: 5/5

Safe to merge — purely a test reorganization with no logic changes.

The change is a mechanical move of a single test case into its correct describe block. No production code is touched, the test body is identical, and the fix directly addresses a prior P2 review comment.

No files require special attention.

_{Reviews (1): Last reviewed commit: "test(gateway): move SecretInputs probe a..." | Re-trigger Greptile}

Closing this as duplicate or superseded after Codex automated review.

This stacked PR is superseded by #72405. The maintainer-owned canonical gateway restart-probe-auth PR now already contains the same SecretInputs regression placement fix, while current main still lacks the underlying gateway auth behavior, so the right cleanup path is to close this stale stacked branch and continue review/landing on #72405.

Best possible solution:

Close this stacked PR as superseded and keep the remaining product/code review focused on #72405. If #72405 lands, it should carry the gateway auth fix, the correctly placed SecretInputs regression, and the existing contributor credit for #57374 and #59439.

What I checked:

• Canonical PR already contains the requested test placement: fix(gateway): keep restart probe auth local #72405 head 8bb983c places the does not resolve remote SecretRefs for local probes test inside describe("resolveGatewayProbeAuthSafeWithSecretInputs"), directly addressing the Greptile organization comment this PR was opened for. (src/gateway/probe-auth.test.ts:169, 8bb983cae17d)
• Original review comment is fully covered by fix(gateway): keep restart probe auth local #72405's current head: The Greptile review on fix(gateway): keep restart probe auth local #72405 flagged the async SecretInputs test as being in the wrong describe block at commit da48b76. The current fix(gateway): keep restart probe auth local #72405 head has force-pushed that test under the matching async describe block. (src/gateway/probe-auth.test.ts:198, 8bb983cae17d)
• This PR is a stale stacked branch, not the canonical implementation: The public API reports this PR targets the fix(gateway): keep restart probe auth local #72405 branch, is dirty/diverged, and includes the older two-commit stack da48b76... plus dbccc2a..., while fix(gateway): keep restart probe auth local #72405 itself is open with a maintainer label and one current commit 8bb983c.... (dbccc2acf09f)
• Current main is not already fixed: Current main at aac83e0 still builds probe credential policy directly from params.cfg and its tests do not contain the new remote-SecretRefs local-probe regression. This is why the close reason is superseded by fix(gateway): keep restart probe auth local #72405, not implemented on main. (src/gateway/probe-auth.ts:18, aac83e00cfe7)
• Security review pass: The PR diff is limited to CHANGELOG.md, src/gateway/probe-auth.ts, and src/gateway/probe-auth.test.ts. It does not touch workflows, dependencies, lockfiles, release scripts, package metadata, downloaded artifacts, or other third-party code execution surfaces; the auth code direction strips remote token/password config from local probe credential selection rather than broadening secret use. (src/gateway/probe-auth.ts:30, dbccc2acf09f)

So I’m closing this here and keeping the remaining discussion on the canonical linked item.

Codex Review notes: model gpt-5.5, reasoning high; reviewed against aac83e00cfe7.