fix(ui): use i18n t() for Node option in exec approvals target select by patricklee001 · Pull Request #68152 · openclaw/openclaw

patricklee001 · 2026-04-17T14:39:01Z

What

Fix hardcoded Node string in ui/src/ui/views/nodes-exec-approvals.ts that bypasses the i18n system.

The translation key nodes.binding.node already exists in all locale files with proper translations (e.g. 节点 for zh-CN, 節點 for zh-TW).

How

Replace the hardcoded string in the exec approvals target <select> with t("nodes.binding.node").

Testing

Open Control UI with zh-CN locale
Navigate to Nodes → Exec Approvals
Confirm the "Node" Host option is no longer hardcoded English

Replaces the hardcoded "Node" string in the exec approvals target <select> with t("nodes.binding.node"), which already has translations in all locale files (e.g. 节点 in zh-CN). The change is correct and the translation key exists. The sibling <option value="gateway"> in the same select remains hardcoded English, leaving a mixed-language display for non-English users (e.g. "Gateway / 节点").

Confidence Score: 5/5

Safe to merge; the change is a minimal, correct i18n fix with no logic impact.

The only remaining finding is a P2 consistency suggestion (translating the sibling Gateway option). No logic, correctness, or security concerns.

ui/src/ui/views/nodes-exec-approvals.ts — the sibling Gateway option on line 258 is still hardcoded English.

Prompt To Fix All With AI

This is a comment left during a code review.
Path: ui/src/ui/views/nodes-exec-approvals.ts
Line: 258

Comment:
**Sibling `Gateway` option still hardcoded**

The `Node` option is now translated but the `Gateway` option immediately above it in the same `<select>` remains a hardcoded English string. Non-English locales will see a mixed select (e.g. "Gateway / 节点" in zh-CN). A `nodes.binding.gateway: "Gateway"` key should be added to `en.ts`, the locale bundles regenerated with `pnpm ui:i18n:sync`, and `Gateway` replaced with `${t("nodes.binding.gateway")}` here.

```suggestion
              <option value="gateway" ?selected=${state.target === "gateway"}>${t("nodes.binding.gateway")}</option>
```

How can I resolve this? If you propose a fix, please make it concise.

_{Reviews (1): Last reviewed commit: "fix(ui): use i18n t() for Node option in..." | Re-trigger Greptile}

greptile-apps · 2026-04-17T14:40:39Z

@@ -256,7 +256,7 @@ function renderExecApprovalsTarget(state: ExecApprovalsState) {
              }}
            >
              <option value="gateway" ?selected=${state.target === "gateway"}>Gateway</option>


Sibling Gateway option still hardcoded

The Node option is now translated but the Gateway option immediately above it in the same <select> remains a hardcoded English string. Non-English locales will see a mixed select (e.g. "Gateway / 节点" in zh-CN). A nodes.binding.gateway: "Gateway" key should be added to en.ts, the locale bundles regenerated with pnpm ui:i18n:sync, and Gateway replaced with ${t("nodes.binding.gateway")} here.

Suggested change

<option value="gateway" ?selected=${state.target === "gateway"}>Gateway</option>

<option value="gateway" ?selected=${state.target === "gateway"}>${t("nodes.binding.gateway")}</option>

Prompt To Fix With AI

This is a comment left during a code review. Path: ui/src/ui/views/nodes-exec-approvals.ts Line: 258 Comment: **Sibling `Gateway` option still hardcoded** The `Node` option is now translated but the `Gateway` option immediately above it in the same `<select>` remains a hardcoded English string. Non-English locales will see a mixed select (e.g. "Gateway / 节点" in zh-CN). A `nodes.binding.gateway: "Gateway"` key should be added to `en.ts`, the locale bundles regenerated with `pnpm ui:i18n:sync`, and `Gateway` replaced with `${t("nodes.binding.gateway")}` here. ```suggestion <option value="gateway" ?selected=${state.target === "gateway"}>${t("nodes.binding.gateway")}</option> ``` How can I resolve this? If you propose a fix, please make it concise.

clawsweeper · 2026-04-27T04:53:43Z

Codex review: needs changes before merge.

Summary
The branch replaces the exec approvals target selector's Node option with t("nodes.binding.node") in ui/src/ui/views/nodes-exec-approvals.ts.

Reproducibility: yes. The code path is deterministic: current main renders Gateway and Node literally, while this PR would render Gateway plus a translated node label and would also change the raw-copy count without updating the baseline.

Next step before merge
This is a narrow PR-branch repair with clear UI/i18n files, no protected labels, and no security-sensitive behavior change.

Security
Cleared: The diff changes only a Control UI label expression and does not touch CI, dependencies, secrets, package metadata, or code execution paths.

Review findings

[P2] Translate the gateway target option — ui/src/ui/views/nodes-exec-approvals.ts:258
[P2] Update the raw-copy baseline with the i18n sync output — ui/src/ui/views/nodes-exec-approvals.ts:259

Review details

Best possible solution:

Localize the complete target selector in one i18n workflow change: add the gateway source key, render both options through t(), and commit generated locale and .i18n output.

Do we have a high-confidence way to reproduce the issue?

Yes. The code path is deterministic: current main renders Gateway and Node literally, while this PR would render Gateway plus a translated node label and would also change the raw-copy count without updating the baseline.

Is this the best way to solve the issue?

No. The PR is a valid partial fix, but the narrow maintainable solution is to update the whole selector and generated i18n metadata together.

Full review comments:

[P2] Translate the gateway target option — ui/src/ui/views/nodes-exec-approvals.ts:258
This change makes only node locale-aware while the adjacent gateway option remains a literal, so non-English locales render a mixed selector such as Gateway / 节点. Add a source key and render both options through t().
Confidence: 0.92
[P2] Update the raw-copy baseline with the i18n sync output — ui/src/ui/views/nodes-exec-approvals.ts:259
Replacing one literal Node removes a raw-copy finding, but the committed baseline still records two Node entries. pnpm ui:i18n:check compares those counts and will report baseline drift until the generated i18n metadata is updated.
Confidence: 0.9

Overall correctness: patch is incorrect
Overall confidence: 0.91

Acceptance criteria:

pnpm ui:i18n:check
pnpm test ui/src/i18n/test/translate.test.ts ui/src/ui/views/nodes.devices.test.ts
pnpm exec oxfmt --check --threads=1 ui/src/ui/views/nodes-exec-approvals.ts ui/src/i18n/locales/en.ts
git diff --check

What I checked:

PR diff only localizes Node: The patch changes the node option to t("nodes.binding.node") while the adjacent gateway option remains the literal Gateway. (ui/src/ui/views/nodes-exec-approvals.ts:258, 6a2f35f48243)
Current main not implemented: At the supplied current-main SHA, both target options are still hardcoded as Gateway and Node, so the PR is not obsolete on main. (ui/src/ui/views/nodes-exec-approvals.ts:258, 225b71db1ee8)
Gateway key missing: nodes.binding.node exists in the English source locale, but there is no sibling nodes.binding.gateway key for the remaining option. (ui/src/i18n/locales/en.ts:135, 225b71db1ee8)
Raw-copy baseline would drift: The baseline records Node twice for nodes-exec-approvals.ts; the PR removes one literal, and the check path compares current counts against the committed baseline and throws on differences. (ui/src/i18n/.i18n/raw-copy-baseline.json:3841, 225b71db1ee8)
Scoped UI i18n workflow: The UI guide says English locale data is the source of truth and generated locale bundles plus .i18n metadata should be updated through pnpm ui:i18n:sync. (ui/AGENTS.md:5, 225b71db1ee8)
Related issue context: The PR references [Bug] Control UI i18n: non-English locale not loaded on initialization + incomplete translation coverage #24803, which reported incomplete Control UI i18n coverage; that issue is closed stale, but its hardcoded-label class matches this selector.

Likely related people:

vincentkoc: Recent history shows Control UI i18n and raw-copy gate work, including commits that localized UI strings, aligned locale outputs, split view type seams, and added the raw-copy baseline gate. (role: recent Control UI i18n maintainer; confidence: high; commits: e8f0f91d2907, 297f4c6e603b, 01058162bebb; files: ui/src/i18n/locales/en.ts, scripts/control-ui-i18n.ts, ui/src/ui/views/nodes-exec-approvals.ts)
steipete: GitHub history shows the exec approvals UI module was split out by this maintainer, with nearby Control UI and i18n script maintenance in the same area. (role: exec approvals UI introducer and adjacent maintainer; confidence: medium; commits: 9fab0d2ced25, 1fb2e18f47e0, 9f19e5be5253; files: ui/src/ui/views/nodes-exec-approvals.ts, scripts/control-ui-i18n.ts)

Remaining risk / open question:

Validation was not executed because this was a read-only review; the repair should run the focused Control UI i18n checks after regenerating locale output.

Codex review notes: model gpt-5.5, reasoning high; reviewed against 225b71db1ee8.

fix(ui): use i18n t() for Node option in exec approvals target select

6a2f35f

openclaw-barnacle Bot added app: web-ui App: web-ui size: XS labels Apr 17, 2026

greptile-apps Bot reviewed Apr 17, 2026

View reviewed changes

github-actions Bot mentioned this pull request May 2, 2026

🦞 OpenClaw Ecosystem Digest 2026-05-02 borq168/big_model_radar#109

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix(ui): use i18n t() for Node option in exec approvals target select#68152

fix(ui): use i18n t() for Node option in exec approvals target select#68152
patricklee001 wants to merge 1 commit intoopenclaw:mainfrom
patricklee001:fix-i18n-node-option

patricklee001 commented Apr 17, 2026

Uh oh!

greptile-apps Bot commented Apr 17, 2026

Uh oh!

greptile-apps Bot Apr 17, 2026

Uh oh!

clawsweeper Bot commented Apr 27, 2026 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

	<option value="gateway" ?selected=${state.target === "gateway"}>Gateway</option>
	<option value="gateway" ?selected=${state.target === "gateway"}>${t("nodes.binding.gateway")}</option>

Uh oh!

Conversation

patricklee001 commented Apr 17, 2026

What

How

Testing

Related

Uh oh!

greptile-apps Bot commented Apr 17, 2026

Greptile Summary

Confidence Score: 5/5

Uh oh!

greptile-apps Bot Apr 17, 2026

Choose a reason for hiding this comment

Uh oh!

clawsweeper Bot commented Apr 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

clawsweeper Bot commented Apr 27, 2026 •

edited

Loading