fix: flip TUI --deliver default to true to prevent stuck spinner#67017
fix: flip TUI --deliver default to true to prevent stuck spinner#67017nightq wants to merge 1 commit intoopenclaw:mainfrom
Conversation
Fixes openclaw#66991 Root cause: --deliver defaults to false, causing the gateway to run the turn without streaming chat.event frames back to the TUI client. The TUI's run-lifecycle state machine never receives the events needed to clear the spinner, leaving it stuck indefinitely. Fix: Changed --deliver default from false to true, and added --no-deliver for explicit opt-out. Per commander.js convention, declaring --deliver first with true default means --no-deliver becomes the negation flag.
|
Closing this PR because the author has more than 10 active PRs in this repo. Please reduce the active PR queue and reopen or resubmit once it is back under the limit. You can close your own PRs to get back under the limit. |
Greptile SummaryThis PR flips Confidence Score: 5/5Safe to merge — single-line default change with correct Commander.js negation pattern and no downstream breakage. All findings are P2 or lower. The root-cause analysis in the PR description is accurate, the fix is correctly scoped, and the Commander.js --no-deliver negation is idiomatic. No logic, data, or security concerns. No files require special attention. Reviews (1): Last reviewed commit: "fix: flip TUI --deliver default to true ..." | Re-trigger Greptile |
Summary
Fixes TUI stuck spinner / "no active run" issue when using default settings.
Root Cause
--deliverdefaults tofalsein the TUI CLI. When delivery is off, the gateway runs the turn to completion but does not streamchat.eventframes back to the TUI client. The TUI's run-lifecycle state machine depends on these events to clear the spinner and finalize the run — without them, the spinner spins forever and Esc prints "no active run".Fix
Changed
--deliverdefault fromfalsetotrue, and added--no-deliverfor explicit opt-out. Per commander.js convention, declaring--deliverfirst with atruedefault means--no-deliverbecomes the negation flag, so existing muscle memory (--deliver) remains harmless.Closes #66991