fix(tui): recover footer state after stale run final#64843
fix(tui): recover footer state after stale run final#64843briandevans wants to merge 1 commit intoopenclaw:mainfrom
Conversation
2e5f80f to
13dc55e
Compare
Greptile SummaryThis PR fixes a bug where the TUI footer could get stuck in Confidence Score: 5/5Safe to merge — targeted, well-tested fix with no P0/P1 issues found. The No files require special attention. Reviews (1): Last reviewed commit: "fix(tui): recover footer state after sta..." | Re-trigger Greptile |
|
Closing this because the remaining blocker is an unrelated CI timeout, not a contained issue in the TUI change itself. I tried the low-cost recovery path first, but rerunning the failed workflow requires repository admin rights, so this is not something I can cleanly fix from the branch. |
Summary
Closes #64825.
A non-local chat final could leave the TUI footer stuck in
streamingwhenactiveChatRunIdhad gone stale, becausefinalizeRun()only settled the footer when the finishing run was still marked active. This lets external final events recover the footer once no tracked runs remain, and adds a regression test that preserves the existing local-run defer behavior from#53115.Validation
pnpm exec vitest run src/tui/tui-event-handlers.test.ts src/tui/tui-session-actions.test.tspnpm exec oxlint src/tui/tui-event-handlers.ts src/tui/tui-event-handlers.test.tspnpm checkstill fails onmainwith the existing repo-wide 442-error oxlint baseline, unchanged by this PR.